GSM modem backend and supporting python modules should be in main project repo about rapidsms HOT 6 CLOSED

Per mail list discussion (http://groups.google.com/group/rapidsms/browse_thread/thread/20aa9e5c6a55643a)

this commit restructures the 'rapidsms/lib/contrib' file layout so that contrib projects can sit in:
rapidsms/contrib//

With their code in a 'lib' sub directory e.g.:
rapidsms/contrib/flotgrapher/lib/flotgrapher

documentation (READMEs) etc... can live in the project dir:
rapidsms/contrib/flotgrapher/README

This commit also adds 'pygsm' as a submodule in the contrib dir:
rapidsms/contrib/pygsm

NOTE: Submodules are tied to specific commits so future changes to rapidsms/pygsm will need to be 'merged' into rapidsms/rapidsms by updating the submodule to point to later commits.

The commit for this fix is:
http://github.com/jwishnie/rapidsms-tostan/commit/a6f93d1f0ddb39bc2bf8da76fe2c5d602c115e28

from rapidsms.

I wouldn't change the rapidsms script. I think you should put the additions to sys.path into rapidsms.manager.

from rapidsms.

Hi Schuyler, thank you for all the reviews!

I put the path manipulation in the script because that's where the script was adding the rapidsms/lib directory and I think it makes sense to do all the path mucking in once place, rather than splitting.

Of course the script needs to add 'lib' at this point so it can find the manager object, which means if I move the 'contrib' code to manager, we still need some path mucking in the rapidsms script...

Rather than hold up this commit, which is really about getting the PyGSM submodule added, I propose we:

1. leave the path mucking in the rapidsms script (which follows the existing pattern)
2. Open a separate issue to decide the correct way to handle path additions--where we should discuss things like app name scoping (see email forum discussion) as well

When we figure out how to handle python path issues in general, we can move the contrib stuff there.

Ok?

from rapidsms.

Hm, I guess that makes sense. Please create the new ticket and then go ahead and merge this.

from rapidsms.

See somewhat wordy issue 68:
http://github.com/rapidsms/rapidsms/issues/#issue/68

from rapidsms.

This commit adds the submodule. The modifications to 'rapidsms' script already slipped in my prior bad commit, so I just didn't revert them:
http://github.com/rapidsms/rapidsms/commit/1d23e2667cca7463e497137533471cab8bc5418f

from rapidsms.