Git Product home page Git Product logo

Comments (3)

rlratzel avatar rlratzel commented on June 22, 2024

Sounds like a good idea. Would these be 3 separate versions of run-dask-process.sh? If so, how would the project-specific code (ie. non-shared) specify which to use, since (at the moment) scripts call run-cluster-dask-jobs.sh and do not directly call run-dask-process.sh? The parameter idea you mentioned might be better in that case.

from multi-gpu-tools.

ayushdg avatar ayushdg commented on June 22, 2024

Yeah, thinking about this a bit more, the projects would call into run-cluster-dask-jobs.sh and then based on an additional parameter it would branch out into calling the specific one of 3 files.
I agree that it would be cleaner to parametrize this into the single run-dask-process.sh file which decides which function to use when building the appropriate scheduler and worker arguments, based on the argument provided.

More concretely it would be something like this:

run-dask-process.sh

function build_tcp_args()
...

function build_ucx_nvlink_args()
...

and so on, where the script could be called as bash run-dask-process.sh tcp scheduler workers either from other projects, or via the run-cluster-dask-jobs.sh file.

@rlratzel If this approach makes sense, happy to take this on and work on the updates

from multi-gpu-tools.

rlratzel avatar rlratzel commented on June 22, 2024

That sounds good to me. I think that will make running on different cluster configurations much easier. Just let me know when your PR is ready for review and I'll gladly take a look. Thanks @ayushdg

from multi-gpu-tools.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.