Git Product home page Git Product logo

Comments (3)

bdice avatar bdice commented on July 4, 2024

@jameslamb Last time this topic came up we concluded not to produce cudf_kafka wheels. There are very few consumers of this library, and at that point, the build system would have required us to build and ship all of libcudf as part of both the cudf-cu(11|12) and cudf_kafka-cu(11|12) wheel if we chose to produce one. Perhaps the new C++ wheels for libcudf would solve part of this problem (building and shipping less in the Python wheels) but we'd probably need libcudf_kafka wheels in addition to libcudf wheels. This would be pretty complicated for very little gain, given the low usage of this library.

I am inclined to add unit tests that are as minimal as possible for conda packages and not ship cudf_kafka wheels at all. That would split the scope of this issue: add unit tests 👍 , add wheels 👎.

References:

from cudf.

jameslamb avatar jameslamb commented on July 4, 2024

Ah!!!

@bdice I didn't realize that we weren't shipping cudf_kafka wheels. I definitely did not mean for this issue to propose doing that! My fault for assuming and not checking more closely 🙈

I'll modify the title and description to reflect that this is only about adding tests for the conda package.

as minimal as possible

100%, my main motivation for this was wanting a test to confirm that cudf_kafka.__version__ is populated and available. I'm not proposing going any further than that.

from cudf.

vyasr avatar vyasr commented on July 4, 2024

Agree with what Bradley said: yes to tests, no to wheels.

from cudf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.