Git Product home page Git Product logo

Comments (8)

eth8505 avatar eth8505 commented on August 16, 2024

Thank you for reporting this. Please note that these are only deprecation notices, the code will still work with 8.1.
I have played around a little, the notices are gone on master as far as I can tell, however there seem to be some problems getting phpunit to run with coverage on 8.0 and 8.1 while the attributes are defined, so I can't create a new release as yet. It is proving more and more tricky to get a single code-base to run notice-free from 5.6 through 8.1 but I'm working on it.

from rapidmail-apiv3-client-php.

bogomolov-dev avatar bogomolov-dev commented on August 16, 2024

Thank you, @eth8505. Compatibility for 5.6 - 8.1 is really hard. But I can understand, if you need this "feature".
I am in the fortunate situation of always being able to work on the latest version.

from rapidmail-apiv3-client-php.

bnetz avatar bnetz commented on August 16, 2024

I really would appreciate a fix. I know that deprecation notices actually are no "danger", but suddenly when we switch to PHP 9 our system stops working and we have a lot of stress.

from rapidmail-apiv3-client-php.

eth8505 avatar eth8505 commented on August 16, 2024

@bnetz PHP9 doesn't even have a release date yet. Just a few weeks ago, PHP 8.2 was released and the next release will be PHP 8.3 to be released in november 2023 afaik. This basically means that 9.0 is at least 2 years out :)
I know deprecation warnings can be annoying, but they can easily be turned off via error_reporting(E_ALL ^ E_DEPRECATED);

from rapidmail-apiv3-client-php.

eth8505 avatar eth8505 commented on August 16, 2024

@bnetz i just released a new version of the API client that should silence the deprecation warnings.

from rapidmail-apiv3-client-php.

bnetz avatar bnetz commented on August 16, 2024

I installed it. Had to add manually the folder "vendor", because an include was missing in example-01-client-initialization.php
Now I get new deprecation warnings like:

Deprecated: Return type of Rapidmail\ApiClient\Service\Response\HalResponsePaginationIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /my/path/src/Service/Response/HalResponsePaginationIterator.php on line 34

from rapidmail-apiv3-client-php.

eth8505 avatar eth8505 commented on August 16, 2024

@bnetz please excuse the oversight, i also added the #ReturnTypeWillChange attribute to that iterator now and also fixed deprecation errors due to deprecated variable interpolation syntax. New release is out.

from rapidmail-apiv3-client-php.

bnetz avatar bnetz commented on August 16, 2024

Yes, this works, thanks a lot, @eth8505 !

from rapidmail-apiv3-client-php.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.