Missing stubs for some functions about levenshtein HOT 5 CLOSED

This is part of v0.19.2

from levenshtein.

Thanks for reporting. I tried to add the type stubs. However I am unsure why it fails the type stub test for jaro and jaro_winkler: https://github.com/maxbachmann/Levenshtein/runs/7311103290?check_suite_focus=true. There should are type hints for them in rapidfuzz.

from levenshtein.

I am not quite sure either what the cause of the error might be. Maybe a stupid idea, but does the action maybe download an older version of the packages from pypi? If not, I think we could manually add the stubs to the __init__.pyi file, like the other functions already in there to please Mypy, however that does sound like a headache to maintain.

Like:

from typing Sequence, Hashable, Callable

...


def distance(
    s1: Sequence[Hashable],
    s2: Sequence[Hashable],
    processor: Optional[Callable] = None,
    score_cutoff: Optional[float] = None,
) -> int: ...
def ratio(
    s1: Sequence[Hashable],
    s2: Sequence[Hashable],
    processor: Optional[Callable] = None,
    score_cutoff: Optional[float] = None,
) -> float: ...
def hamming(
    s1: Sequence[Hashable],
    s2: Sequence[Hashable],
    processor: Optional[Callable] = None,
    score_cutoff: Optional[float] = None,
) -> int: ...
def jaro(
    s1: Sequence[Hashable],
    s2: Sequence[Hashable],
    processor: Optional[Callable] = None,
    score_cutoff: Optional[float] = None,
) -> float: ...
def jaro_winkler(
    s1: Sequence[Hashable],
    s2: Sequence[Hashable],
    processor: Optional[Callable] = None,
    score_cutoff: Optional[float] = None,
) -> float: ...

Again, probably not the ideal way to go about things. In any case, thanks for responding so quickly.

from levenshtein.

I am not quite sure either what the cause of the error might be. Maybe a stupid idea, but does the action maybe download an older version of the packages from pypi?

no this appears to be the newest version

If not, I think we could manually add the stubs to the init.pyi file, like the other functions already in there to please Mypy, however that does sound like a headache to maintain.

Since those are not going to change a lot I guess this would be fine. Do you want to open a PR with these stubs?

from levenshtein.

Yes, I can do that.

from levenshtein.