Comments (6)
Hi @dominikstrb ! This is interesting, thanks for sharing! I, unfortunately, don't have access to the book, any chance that you could send me a screenshot of the relevant paragraph/equation?
Here are a few thoughts:
-
I would probably leave the current method as the default, to be consistent with the Matlab circular toolbox.
-
However, we can indeed add an optional argument for this method. What do you think is the most appropriate argument name?
correction_uniform=True
,method='js'
, or any other ideas? -
Do you know of any packages / softwares (R, Matlab, Python, SPSS) that implement this equation? It would be better for testing purposes.
Thanks!
Raphael
from pingouin.
Thanks for your quick answer!
I took a screenshot of the relevant page:
My answers to your thoughts:
- Definitely!
- I think as long as there's only one alternative method, one boolean kwarg should be enough, if the user is referred to the relevant literature.
- I wasn't able to find one, unfortunately. Most circular statistics packages (like this one) seem to build upon Philipp Berens' MATLAB toolbox. I'll make sure to test the two methods against one another with simulations before proposing any changes to Pingouin.
If you're okay with it, I could start a pull request that keeps the default method, but allows to enable the alternative with a kwarg.
Best,
Dominik
from pingouin.
Hi @dominikstrb ! Yes, please start working on a pull request :) Make sure to push on the develop, and not the master, branch. Thanks!
from pingouin.
Hi @dominikstrb! Just wanted to follow-up on the PR. Please let me know if you need any help, or, if you're too busy at the time I can also quickly add it.
Thanks!
Raphael
from pingouin.
Thanks for reminding me. I was in fact quite busy the past few weeks, but I managed to create the PR this morning. Hope everything is alright!
from pingouin.
Thanks for the PR @dominikstrb ! Closing the issue now.
from pingouin.
Related Issues (20)
- Change solver in sklearn.LogisticRegression HOT 1
- Two new test failures fails in Fedora Rawhide HOT 3
- Chi-Square Identified Significant Groups, Now Which One is More Significant? HOT 2
- chi2_independence p-values are possibly reversed HOT 2
- Remove call to sns.despine in paired_plot
- Rename development branch HOT 1
- Potential fix for numerical instabilities for corr and partial_corr: z-normalize HOT 1
- FloatingPointError: divide by zero encountered in double_scalars when calculating t test HOT 1
- pandas > 1.5 reason? HOT 2
- Mann-Whitney U (mwu): Order of `x` and `y` determines sign of rank-biserial correlation (RBC) HOT 4
- Two-Way-ANOVA results do not show p-values. HOT 3
- How to handle categorical covariates with more than two levels in pg.partial_corr? HOT 1
- Bug in ANCOVA function (ValueError: assignment destination is read-only) HOT 1
- Feature request: add CI to ANOVA/Tukey HOT 1
- chained assignment issue HOT 1
- pg.bayesfactor_pearson(r=-0.856, n=64, alternative="greater") returns wrong BF value
- Mann-Whitney U (mwu): the computation of rank-biserial correlation (RBC) is problematic
- How to solve RuntimeWarning: invalid value encountered in double_scalars and RuntimeWarning: Mean of empty slice. HOT 2
- Computation for Cohen's d in ttest seems to use the wrong fomula
- Effect sizes Cohens D and Hedges g with pingouin differ from R
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pingouin.