Git Product home page Git Product logo

Comments (19)

AntM90 avatar AntM90 commented on June 6, 2024 3

@rannn505 Please can you merge this PR, cause everything works great except that.

Thanks :)

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024 1

Can you try my fork and then report back to us if it meets your needs?

https://github.com/BenjaminMichael/node-powershell

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024 1

don't forget you need to pass a parameter to use PowerShell Core "pwsh"

shell = require('node-powershell')
ps = new shell(usePwsh: true)

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

PS to invoke powershell from the terminal (at least with my install) you have to run pwsh and not powershell, perhaps that's why?

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

what versions of: node, Mac OS, node-powershell, and powershell are you on?

I would mostly be worried about what modules and/or dotnetlibraries that beautifier is dependent upon because youre using powershell on a mac.

the terminal command 'powershell' opens PS on my Mac OS Sierra 10.12.6

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

Node: 8.9.1
MacOS: 10.13.1
node-powershell: 3.3.1
powershell: 6.0.0

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

"PowerShell Core 6.0.0-beta.9 the binary for PowerShell Core was renamed from powershell.exe and powershell on Windows and Linux/Unix/macOS respectively to pwsh.exe and pwsh"
source: the internet

time for a pull request?

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

Seems like you could make an environmental variable as a workaround but Apple had made that really tricky you have to make a plist (see https://apple.stackexchange.com/questions/106355/setting-the-system-wide-path-environment-variable-in-mavericks)

It might be easier to uninstall and reinstall 6.0.0-beta.2 or another version

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

Any update on this?

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

It took me a while to understand this issue. They renamed it because Windows PowerShell and PowerShell-Core need to be able to run side by side. For this reason it makes sense to just make it an optional parameter with the default being Windows Powershell. I made a PR.

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

@BenjaminMichael @rannn505 I see a PR was opened for this. Any update?

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

It does. I created the shell like this (it's in coffeescript):

shell = require('node-powershell')
ps = new shell(usePwsh: true)

And it spawned fine.

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

@BenjaminMichael @rannn505 any update on this?

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

@szeck87 you might want to check out https://github.com/IonicaBizau/powershell

It is based on node-powershell but a little cleaner/simpler. Lacking test coverage but actively maintained and they already merged my pwsh by parameter PR.

from child-shell.

rannn505 avatar rannn505 commented on June 6, 2024

@szeck87 @BenjaminMichael ,
Hey friend sorry it took a long time, I was on a very long trip, I promise to look at everything that has happened since my last commit and to release a new version very soon. Thank you for your patience 🥇.

from child-shell.

stevenzeck avatar stevenzeck commented on June 6, 2024

@BenjaminMichael I gave that one a try, unfortunately I'm converting javascript to coffeescript and something is off as I keep getting data is not defined using that package.

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

Just wait for Rann to merge my PR it shouldn't take long since its 1.5 lines of changes

from child-shell.

peterclemenko avatar peterclemenko commented on June 6, 2024

@rannn505 could you please merge this
@BenjaminMichael could you please put this on NPM in the mean time

from child-shell.

BenjaminMichael avatar BenjaminMichael commented on June 6, 2024

@AoiGhost i published it as an npm package called node-powershellcore

from child-shell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.