Comments (19)
@rannn505 Please can you merge this PR, cause everything works great except that.
Thanks :)
from child-shell.
Can you try my fork and then report back to us if it meets your needs?
https://github.com/BenjaminMichael/node-powershell
from child-shell.
don't forget you need to pass a parameter to use PowerShell Core "pwsh"
shell = require('node-powershell')
ps = new shell(usePwsh: true)
from child-shell.
PS to invoke powershell from the terminal (at least with my install) you have to run pwsh
and not powershell
, perhaps that's why?
from child-shell.
what versions of: node, Mac OS, node-powershell, and powershell are you on?
I would mostly be worried about what modules and/or dotnetlibraries that beautifier is dependent upon because youre using powershell on a mac.
the terminal command 'powershell' opens PS on my Mac OS Sierra 10.12.6
from child-shell.
Node: 8.9.1
MacOS: 10.13.1
node-powershell: 3.3.1
powershell: 6.0.0
from child-shell.
"PowerShell Core 6.0.0-beta.9 the binary for PowerShell Core was renamed from powershell.exe and powershell on Windows and Linux/Unix/macOS respectively to pwsh.exe and pwsh"
source: the internet
time for a pull request?
from child-shell.
Seems like you could make an environmental variable as a workaround but Apple had made that really tricky you have to make a plist (see https://apple.stackexchange.com/questions/106355/setting-the-system-wide-path-environment-variable-in-mavericks)
It might be easier to uninstall and reinstall 6.0.0-beta.2 or another version
from child-shell.
Any update on this?
from child-shell.
It took me a while to understand this issue. They renamed it because Windows PowerShell and PowerShell-Core need to be able to run side by side. For this reason it makes sense to just make it an optional parameter with the default being Windows Powershell. I made a PR.
from child-shell.
@BenjaminMichael @rannn505 I see a PR was opened for this. Any update?
from child-shell.
It does. I created the shell like this (it's in coffeescript):
shell = require('node-powershell')
ps = new shell(usePwsh: true)
And it spawned fine.
from child-shell.
@BenjaminMichael @rannn505 any update on this?
from child-shell.
@szeck87 you might want to check out https://github.com/IonicaBizau/powershell
It is based on node-powershell but a little cleaner/simpler. Lacking test coverage but actively maintained and they already merged my pwsh by parameter PR.
from child-shell.
@szeck87 @BenjaminMichael ,
Hey friend sorry it took a long time, I was on a very long trip, I promise to look at everything that has happened since my last commit and to release a new version very soon. Thank you for your patience 🥇.
from child-shell.
@BenjaminMichael I gave that one a try, unfortunately I'm converting javascript to coffeescript and something is off as I keep getting data is not defined
using that package.
from child-shell.
Just wait for Rann to merge my PR it shouldn't take long since its 1.5 lines of changes
from child-shell.
@rannn505 could you please merge this
@BenjaminMichael could you please put this on NPM in the mean time
from child-shell.
@AoiGhost i published it as an npm package called node-powershellcore
from child-shell.
Related Issues (20)
- Allow for PWSH Custom Paths
- proper use of ps.dispose HOT 1
- PS_CMD_FAIL_ERROR: Error code = 0x80005000 HOT 1
- [Node-Bash] Command invocation failed
- Documentation page doesn't work HOT 3
- TypeError: shell is not a constructor HOT 7
- NPS> PS process ***** exited with code 4294901760
- getting powershell output back into javascript HOT 5
- Run without PS
- How to avoid arbitrary command injection
- Text decoding error when returning to resolve characters containing non-English HOT 1
- Documentation links fail HOT 1
- How to use Child-Shell HOT 4
- broken readme links please validate
- debug does not export Debugger
- debug does not export Debugger;
- ProcessError: Shell process (somePID) exited. originalError: undefined, exitCode: null, signalCode: 'SIGABRT'
- Is repo still maintained? HOT 3
- await PowerShell.$`${myVariable}` always stuck
- .addCommand not a valid method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from child-shell.