Git Product home page Git Product logo

Comments (5)

PhillipsOwen avatar PhillipsOwen commented on June 8, 2024

i will correct.

from answercoalesce.

PhillipsOwen avatar PhillipsOwen commented on June 8, 2024

The TRAPI 1.1 spec does not specify the "attributes" property for result node bindings. the spec is generous in this case and will allow basically anything you put in there.

however, node normalization currently fails when a non-hashable type (in this case the attributes dict) is encountered while merging node data. in addition, node norm does not normalize any curie values in the results. Node normalization will have to be modified if this change is implemented.

it is not known at this time if any other downstream components would have an issue here as well.

from answercoalesce.

cbizon avatar cbizon commented on June 8, 2024

I think it makes sense to robustify nn to handle properties of this type, and to update the binding properties to match other trapi properties, even if it is not required.

from answercoalesce.

PhillipsOwen avatar PhillipsOwen commented on June 8, 2024

understood, thanks!

from answercoalesce.

mmersmann avatar mmersmann commented on June 8, 2024

What we're doing is TRAPI compliant, but we would like to make TRAPI require us to include standards around this part of the message. Phil is creating an issue in the TRAPI repo to add standards around attributes in this part of the message.

from answercoalesce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.