Git Product home page Git Product logo

Comments (6)

ranisalt avatar ranisalt commented on August 15, 2024

I'm pretty confident the error is not with the build system, since for every push it is integrated with Codeship so it is rebuilt on a clean machine. It might be related to Argon2 updates instead.

from node-argon2.

cgmb avatar cgmb commented on August 15, 2024

Unfortunately, that link appears to be private. Without an account, you're prompted to sign up or sign in. With an account, it says: Oops! You can't access this page.

I'll try to delve a little deeper into the issue, but not much changed between 0.4.1 and 0.4.2. I'm fairly sure it's a result of the changes to binding.gyp and package.json.

from node-argon2.

ranisalt avatar ranisalt commented on August 15, 2024

You need to be logged in but you don't need special privileges to see it. I moved to Codeship since Travis was becoming a pain in the ass to maintain, but I do consider returning since it's better to visualize.

See, since the preinstall script updates the Argon2 repository, it is possible to be the problem. On a clean repository, can you npm install [email protected]? I can with no problems @ GCC 5.3

from node-argon2.

cgmb avatar cgmb commented on August 15, 2024

I went over to Digital Ocean, booted up a fresh Ubuntu 15.10, 32-bit VM and ran the script below.

It successfully installs and runs v0.4.1 but fails to build v0.4.2.

apt-get install -y curl
curl -sL https://deb.nodesource.com/setup_5.x | sudo -E bash -
apt-get install -y git build-essential python nodejs
npm install -g node-gyp
useradd -d /home/demo -m demo
su - demo -c 'git clone https://gist.github.com/8ca4094a820612fbba9b.git v041 && cd v041 && npm install && node main.js'
su - demo -c 'git clone https://gist.github.com/4027504aac16e86ffc61.git v042 && cd v042 && npm install && node main.js'

from node-argon2.

cgmb avatar cgmb commented on August 15, 2024

So, mystery solved.

node-gyp configure rebuild --verbose was helpful in tracking this down. After discovering that the difference boiled down to -march=native, I tracked it back to a difference in default instruction support for 32-bit and 64-bit builds.

I also contacted CodeShip with regards to the error in accessing the link you posted. Unfortunately, it seems that it's not possible to make it public:

None of our codeship projects are publicly accessible (yet). The owner of the project needs to add you as a team member of the project in order for you to receive access.

(No need to do that, though. I can get along fine without it.)

from node-argon2.

ranisalt avatar ranisalt commented on August 15, 2024

So, node-gyp (or gyp itself) uses the very safe -march=native as default, huh?

I'm going to change to Travis since I want the build and test to be transparent.

from node-argon2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.