Comments (5)
Gonna have a look.
from node-argon2.
Please checkout the bluebird branch, I fixed it so you can change the Promise
property of the exported object to use a custom promise.
See an example on bluebird.spec.js, it's really a one-liner.
If it works for you, please open a pull request for that branch.
from node-argon2.
As far as I can tell, it works. My code once again catches the right errors, at the right places.
However, I cant for the life of me get npm to actually fetch and install it properly, by the github reference. But cloning, init'ing, and building with node-gyp manually, makes it work perfectly! 👍
from node-argon2.
Yeah, npm makes it pretty hard to sync to branches.
Did you feel any improvements from using Bluebird? It plays nice with basic, default hash but it doesn't scale time and memory cost very well to me.
from node-argon2.
Do you have any advice for how something like this could easily be handled? Currently I have an install-argon.sh script being executed during install, after having run npm-install on the project.
The improvements I felt, was actual compatibility with my own codebase. I've been relying pretty heavily on the Bluebird's filtered catches, in order to create what I feel is more readable code. I was using a BCrypt library previously, which was "promisified" using Bluebird.
But everything involved with hashing and verification unfortunately completely broke, after plugging in your Argon2 library (which supposedly is superior). So unfortunately, that is the only aspect I can even argue improvements -- which is horribly un-scientific.
from node-argon2.
Related Issues (20)
- Vulnerable downstream dependency HOT 6
- Hash in .Net and Verify in node.js HOT 6
- Cannot build anymore from yesterday: Cannot find module './**/*' HOT 8
- How to cache the Argon2 binary for CI? HOT 1
- Bun support HOT 1
- how to install with local argon2.node HOT 1
- v0.40.0-alpha.2 raises ts errors HOT 2
- node18.14.0 node-gyp10.0.1 Error message reported during installation of argon2 HOT 2
- How to hash without salt? HOT 2
- Feat request: synchronous version HOT 5
- Crash with docker HOT 2
- `defaults` is no longer exported in v0.40.0 HOT 2
- Mismatching version numbers on github releases and npm (0.40.0 vs 0.40.1) HOT 2
- node-gyp-build error HOT 4
- Doesn't work in the node:20-alpine image docker HOT 24
- Type regression between v0.31.2 and v0.40.1 HOT 5
- ReferenceError: require is not defined HOT 1
- Centos8 error: "symbol lookup error: undefined symbol: argon2_ctx" HOT 1
- Invalid argument on verify method HOT 4
- 0.40 prebuild fails on Debian bullseye arm64 linux as GLIBC 2.34 is required HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-argon2.