Not working on Windows about node-argon2 HOT 7 CLOSED

I fear that VS 2013 is not fully compliant with C++11 (source), though I'm trying to configure appveyor to build on Windows too.

I myself can't try since I don't have Windows anywhere, so I'm going to mark as help wanted.

from node-argon2.

It looks like constexpr is supported on Visual Studio 2015 (according to this), which is a little bit harder to set up with node-gyp, I'll try if I can compile it with VS2015...

Can't you run Windows in a VM?

from node-argon2.

With VS2015 I get only 2 errors:

..\src\argon2_node.cpp(25): error C3249: illegal statement or sub-expression fo
r 'constexpr' function [C:\Users\Wout\projects\node-argon2\build\argon2.vcxproj
]
..\src\argon2_node.cpp(33): error C2131: expression did not evaluate to a const
ant [C:\Users\Wout\projects\node-argon2\build\argon2.vcxproj]

And when I open it in the VS2015 IDE I get the errors:

• constexpr function return is non-constant on the word static_cast on line 25
• function call must have a constant value in a constant expression on the word base64Length on line 33

from node-argon2.

I'm going to replace the base64Length function for one that does not require math or static cast.

from node-argon2.

from node-argon2.

You can edit the README yourself @wb9688 by visiting the file, then click on the pencil icon between the monitor & tashcan.

from node-argon2.

Yes, please do, I've been in a hurry this week because of university 👍

from node-argon2.