Git Product home page Git Product logo

Comments (11)

mndominguez avatar mndominguez commented on May 18, 2024 1

I'm having this same issue. @ramswaroop do you think you can merge the PR? If the issue is that @lurraca did not change the code to check both event types, I can go ahead and do it. Thanks, great project BTW!

from jbot.

rampatra avatar rampatra commented on May 18, 2024

Hmm, it never happened to me. Let others comment on it too. Will keep this issue open.

from jbot.

sunayansaikia avatar sunayansaikia commented on May 18, 2024

Found the root cause. Inside the following method,
public final void handleTextMessage(WebSocketSession session, TextMessage textMessage)()

Root cause - Slack's im_created event gets triggered while talking to a newly added user.
As mentioned in this im_created event guide, this event should usually be followed by a im_open event which your code is looking for. But, that's not the case. I think, that's what they meant by 'usually'? Whatever be the case, I have added the check for the im_created in the code.

[Note]: Check this bug I raised in slack issues.

from jbot.

rampatra avatar rampatra commented on May 18, 2024

Glad your issue is resolved.

from jbot.

lurraca avatar lurraca commented on May 18, 2024

@sunayansaikia I am facing the same issue. What do you mean by

added the check for the im_created in the code.

?

from jbot.

lurraca avatar lurraca commented on May 18, 2024

Ok, I think I got it.

I made the change on the Jbot source code to check for im_created and add the channel to DmChannels list, so when that new user sends a direct message to the bot, jbot is able to determine that is a DIRECT_MESSAGE. @ramswaroop is this something that you would like me to send a PR to fix it?

from jbot.

rampatra avatar rampatra commented on May 18, 2024

Hi @lurraca, looks like jbot should check for both the events. Yes, definitely you can send a PR for the fix. Thanks a mil for contributing. 👍

from jbot.

rampatra avatar rampatra commented on May 18, 2024

@mndominguez okay I will do that today 👍

from jbot.

rampatra avatar rampatra commented on May 18, 2024

@mndominguez I just merged @lurraca PR #57.

from jbot.

mndominguez avatar mndominguez commented on May 18, 2024

@ramswaroop fantastic, thank you! Is the fix going to be on a new build on Maven Central?

from jbot.

rampatra avatar rampatra commented on May 18, 2024

@mndominguez no it's not gone to maven yet. I will release it after some tests which may take some days as I am working on other new features as well.

from jbot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.