Git Product home page Git Product logo

Comments (3)

jcheng5 avatar jcheng5 commented on July 30, 2024

This doesn't sound right...

  1. I think you're seeing an array because jQuery actually is loaded (as it always is in a Shiny context) but jQuery was clobbered or the instanceof check is failing. If jQuery isn't loaded, the only place this is called should be passing documentElement (here), and that's certainly a single element, not an array.
  2. This code only executes in Shiny mode, where jQuery is guaranteed to be available.

Once rbokeh clobbers jQuery, I think we basically have to consider Shiny and htmlwidgets to have undefined behavior. I've seen that even simple event subscriptions don't work right once you've loaded two copies of jQuery. I strongly recommend that you NOT paper over the double-jQuery issue by trying to fix the specific symptoms called out in this bug, and instead see if you can come up with a PR for bokeh to unbundle these pieces.

from htmlwidgets.

timelyportfolio avatar timelyportfolio commented on July 30, 2024

I agree unbundling will be the only stable solution. Even when I do force it to work, it doesn't due to the multiple jQuery. However, just for my own clarity, this line

 return scope.querySelectorAll(selector);

will never be called in Shiny mode? So, we would never expect anything other than jQuery in this line?

// Only return elements that are Shiny outputs, not static ones
var dynamicResults = results.filter(".html-widget-output");

Thanks for looking into this.

from htmlwidgets.

timelyportfolio avatar timelyportfolio commented on July 30, 2024

don't think there is any reason to keep this open. Thanks @jcheng5 for your help and clarification.

from htmlwidgets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.