Git Product home page Git Product logo

Comments (13)

klslz avatar klslz commented on July 18, 2024 2

Hi.
This ogg thing also broke my installation. I've plenty of users complaining.
You also need to consider that flac can be compiled without ogg!

You need to cope with the issue within squeezelite properly! You can't force the world to change anything on flac.

That's really bad. Didn't happen in years. Better roll that stuff back until you find a proper solution.

flac.c: In function ‘load_flac’:
flac.c:351:12: error: ‘struct flac’ has no member named ‘FLAC__stream_decoder_set_ogg_chaining’; did you mean ‘FLAC__stream_decoder_init_ogg_stream’?
  351 |         f->FLAC__stream_decoder_set_ogg_chaining = dlsym(handle, "FLAC__stream_decoder_set_ogg_chaining");
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |            FLAC__stream_decoder_init_ogg_stream

from squeezelite.

philippe44 avatar philippe44 commented on July 18, 2024

You need a patch flac version. See past PR on squeeselite

from squeezelite.

hismastersvoice avatar hismastersvoice commented on July 18, 2024

Thank for the fast response.

Sorry for the stupid question, but how can I patch Flac?
I don't find info's what to do.

Thanks in advance.

from squeezelite.

philippe44 avatar philippe44 commented on July 18, 2024

Details here #197

from squeezelite.

hismastersvoice avatar hismastersvoice commented on July 18, 2024

Thanks again.

Is there a way without patching FLAC?

from squeezelite.

philippe44 avatar philippe44 commented on July 18, 2024

Why would you want to do that? You just have to pull that flac version. Otherwise, edit the flac.c and comment-out the code that setup chaining. Flac won't support sone OggFlac than.

from squeezelite.

philippe44 avatar philippe44 commented on July 18, 2024

You can also remove the flag USE_LIBOGG at compilation

from squeezelite.

hismastersvoice avatar hismastersvoice commented on July 18, 2024

Thanks, works now.
For the next updates I patch FLAC.

from squeezelite.

philippe44 avatar philippe44 commented on July 18, 2024

Are you just building for yourself?

from squeezelite.

hismastersvoice avatar hismastersvoice commented on July 18, 2024

Not only for myself, for my project.
I've tested it this morning with different FLAC, OGG Files and Streams. Work fine for now.

from squeezelite.

ralph-irving avatar ralph-irving commented on July 18, 2024

r1477 compiles with unpatched and older libflac versions as long as you are using a newer gcc and USE_LIBOGG is NOT defined.

from squeezelite.

ralph-irving avatar ralph-irving commented on July 18, 2024

Hi. This ogg thing also broke my installation. I've plenty of users complaining. You also need to consider that flac can be compiled without ogg!

You need to cope with the issue within squeezelite properly! You can't force the world to change anything on flac.

That's really bad. Didn't happen in years. Better roll that stuff back until you find a proper solution.

Better than that, how about I fix the build failure and move on? Or maybe I should make the repository private and move on? I don't take kindly to persons telling me how I should spend MY time fixing things for them for free.

from squeezelite.

philippe44 avatar philippe44 commented on July 18, 2024

Doing these changes is not easy and I think you should seriously reconsider the tune of your comment and its entitlement level. This is free software, you can fork it and fix it by yourself.

from squeezelite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.