"make install" doesn't return a non-zero exit code on failure about star HOT 7 CLOSED

Would you be able to specify which versions you're working with? The zero-on-test-fail was an issue in Rakudo that was fixed on September 13, 2016

from star.

2016.10.

On Nov 3, 2016 00:30, "Zoffix Znet" [email protected] wrote:

Would you be able to specify which versions you're working with? The
zero-on-test-fail was an issue in Rakudo that was fixed on September 13,
2016
rakudo/rakudo@626a222

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#78 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACw9b9DBpMxPq5gak2XA8dZpQhiypriks5q6R0jgaJpZM4Knynt
.

from star.

This is still an issue with 2017.01 (happens to be due to the issue described in #77):

$ make install; echo $?
[...]
t/P.t (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: Bad plan.  You planned 1 tests but ran 0.
Files=1, Tests=0,  3 wallclock secs
Result: FAILED

0

I.e. a test suite fails, and 'make install' returns 0. So I'm still
grepping its output for FAIL to see if it failed.

from star.

Dug a bit into it and it looks like installation still proceeds even if there are test failures in modules. It still continues to install a module after failed tests, even though if you run make install twice it does abort and the error code is available in $?

Does anyone know if that's done on purpose and is desirable behaviour?

from star.

It is currently desirable behaviour on Windows since it's rare for all module tests to pass there (due to lack of upstream testing on Windows). I've considered dropping Windows binary builds and marking R* WIndows as "broken" for this reason. But I did get a lot of complaints in the past when MSI weren't shipped and my feeling is getting mostly working code out there in the hope that some Windows dev fixes the small number of issues is best right now.

But the error handling should be fixed to spot problems on the better supported platforms with an "override" switch of some sort to allow the Windows MSI build.

from star.

See #21

from star.

The current iteration of Rakudo Star doesn't test modules during installation anymore, so this issue should be resolved as such.

from star.