Different peer, same peer ID? about libtorrent HOT 7 CLOSED

download->initialize(infoHash, PEER_NAME + rak::generate_random<std::string>(20 - std::string(PEER_NAME).size()));

It seems to be doing everything correctly, and this code hasn't been touched in years. Is this something you see from one user, or does it happen with multiple users?

from libtorrent.

Haven't checked yet. How is the generator being initialized / seeded?

from libtorrent.

    cachedTime = rak::timer::current();

    srandom(cachedTime.usec());
    srand48(cachedTime.usec());

The generate_random method uses 'random()', so without any more informatino it's difficult to figure out what's going on.

from libtorrent.

About 20 bits of entropy, that's not a lot.
And what if two processes hit that line at the same microsecond?

from libtorrent.

6697806

Added xor of the pid and ppid.

from libtorrent.

That's still just 20 bits, isn't it?

from libtorrent.

Same thing again..
A user running rtorrent on multiple systems has the same peer ID & key for both..

from libtorrent.