Git Product home page Git Product logo

Comments (5)

jomajm avatar jomajm commented on May 25, 2024

Here is an example, first announce response is correct (tracker interval is 30 minutes), and all other are errors

announce timestamps:
1345798762 | this is first announce, event = started
1345798795 |
1345798800 |
1345798810 |
1345798830 |
...

this is single tracker torrent btw and I'm using latest git code. Why is this happening ?

Thanks !

from libtorrent.

rakshasa avatar rakshasa commented on May 25, 2024

When requesting more peers, if denied it goes into failure mode rather than waitiing until min request timer finishes.

I'll look into a fix.

from libtorrent.

rakshasa avatar rakshasa commented on May 25, 2024

The min_interval issue has been fixed.

from libtorrent.

pyroscope avatar pyroscope commented on May 25, 2024
--- src/torrent/tracker.h,orig  2012-09-25 21:56:47.607686352 +0200
+++ src/torrent/tracker.h   2012-09-25 22:01:13.731684611 +0200
@@ -150,4 +150,4 @@

-  void                set_normal_interval(int v)            { if (v >= 600 && v <= 3600) m_normal_interval = v; }
-  void                set_min_interval(int v)               { if (v >= 300 && v <= 1800) m_min_interval = v; }
+  void                set_normal_interval(int v)            { m_normal_interval = std::min(std::max(600, v), 3600); }
+  void                set_min_interval(int v)               { m_min_interval = std::min(std::max(300, v), 1800); }

This also contributes to the problem (and this diff fixes it), since current code ignores values that are considered out of range, instead of normalizing them into the range,

from libtorrent.

rakshasa avatar rakshasa commented on May 25, 2024

Fixed.

from libtorrent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.