Comments (6)
That is what a fork it for adding your additions so they can be tested among many users. That is also how we can take the best parts of all the plugins to create 1 master plugin. If you wouldn't mind could you create a fork and add your chamberlain plugin modification to it.. Would love to add support for the lights. :)
from homebridge-platform-myq.
Lift master plugin does not do periodic check door state and does not support light switch. This project is well tested and also maintained regularly. It is your own choice to pick which one you use. Thanks for your advice though.
from homebridge-platform-myq.
I agree that it should be on one plugin - the liftmaster one.
from homebridge-platform-myq.
I'm not sure that I agree with the people telling @rainlake to re-do his work as a fork of the Liftmaster plugin. Frankly @rainlake's plugin already works better and has more features - and has a more sensible name too. It supports my lights and gets my garage door status correct, which the Liftmaster plugin never did (and a pull request to fix this has been sitting unresolved since February).
It's not like a homebridge plugin like this contains such a vast amount of code that it's a huge waste to write another...
from homebridge-platform-myq.
i don't disagree with the naming being more sensible here. What i don't agree with is having two competing implementations when the community can instead work together on a common platform. By having two, it reduces the pace of improvement on both implementations.
I think there does need to be a discussion of whether this one becomes the main implementation or the lift master one becomes the main one. That discussion should happen in the open with the pro's and con's of each implementation and deciding together which one should be converged towards.
from homebridge-platform-myq.
Rainlake you on Slack? What your username?
from homebridge-platform-myq.
Related Issues (15)
- MyQ Lights HOT 5
- Incorrect "Opening" status HOT 5
- Wouldn't close the door if it was stopped HOT 1
- Opening the garage door is stuck in 'Opening' state, doesn't reach 'Open' for me HOT 1
- Plugin generates an error and crashes homebridge
- The requested platform 'MyQ' was not registered by any plugin HOT 4
- Login Errors HOT 7
- API changes break homebridge-platform-myq HOT 4
- Fails to add accessory b/c of missing displayName HOT 4
- Two Garages HOT 4
- MyQ Light Switch & Lamp Control Modules HOT 3
- Q: why the use of `moment(...)` when calling `this.log(...)` HOT 3
- Q: why two accessories instead of one? HOT 3
- homebridgeplatform-myq vs homebridge-liftmaster HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from homebridge-platform-myq.