Feature request: Provide a hook to handle/report exceptions in processes forked by `Supervisor::ForkSupervisor` about solid_queue HOT 6 CLOSED

Oh, interesting! It seems like Rollbar doesn't provide a subscriber for Rails's error reporting? Exceptions like this one are handled by Rails's error reporting automatically so you shouldn't need to configure anything... but it's possible Rollbar is outdated?

from solid_queue.

Oh, nice! 🙏 Thanks a lot for posting that information.

from solid_queue.

Oh, interesting! It seems like Rollbar doesn't provide a subscriber for Rails's error reporting? Exceptions like this one are handled by Rails's error reporting automatically so you shouldn't need to configure anything... but it's possible Rollbar is outdated?

Ah, I wondered whether that was the case. Is there somewhere in solid_queue other than in on_thread_error that reports exceptions to Rails' error reporting? I tried printing something to stdout from within that on_thread_error block and it didn't seem to print anything when the exception occurred, but perhaps that stdout wasn't connected to the parent process stdout...? I guess my question is: are you confident that the exception above would have been caught by the on_thread_error block...?

If so, I'll close this and work on getting Rollbar to play nicely with Rails error reporting...

PS Thanks for the great library! ❤️

from solid_queue.

Thanks a lot @floehopper! 🙏

I guess my question is: are you confident that the exception above would have been caught by the on_thread_error block...?

No, it wouldn't have been captured by that, but I think it should have been handled by Rails's error reporter regardless, being run within executor.wrap. How does Rollbar hook into Rails errors? Sentry, for example, registers an error subscriber during initialization, and it definitely got this kind of error 🤔

In any case, I realise the way on_thread_error works is quite confusing as it is now. It was something I added in the very beginning, before even having a supervisor that forked processes, so I'll revisit it to make it clearer.

from solid_queue.

No, it wouldn't have been captured by that, but I think it should have been handled by Rails's error reporter regardless, being run within executor.wrap.

Ah, I missed that - thanks so much for explaining.

I have just verified that the ArgumentError exception I was seeing is indeed reported successfully via the Rails error reporter, so I'm going to close this and focus on sorting out the Rollbar integration with the Rails error reporter.

from solid_queue.

Just in case anyone else comes across this - Rollbar added support for the Rails error reporter in v3.6.0.

from solid_queue.