`ActiveSupport::BroadcastLogger` with `ActiveSupport::TaggedLogging` throws `no implicit conversion of String into Integer (TypeError)` about rails HOT 3 OPEN

I debugged a little bit more and somehow when configuring the broadcast log with logs without the tagged logger. It works fine.
And also when I use just a log with tagged logger, it works fine.

The problem is with tagged logger and broadcast logger.

Also I debugged the ActionDispatch::RequestId and the problems seems that when configuring the TaggedLoggingandBroadcastLogger` it changes the arguments of the block.

@app.call(env).tap do |_status, headers, _body|     
    headers[@header] = req.request_id
  end

With the TaggedLogging and BroadcastLogger the both the _status and headers is the Array composed of [status, headers] that why the line that set the request_id throw the error. headers is an array and @header is the key for the header "x-request-id"

Without hte TaggedLogging, the arguments of the block are correctly decomposed.

I could try to fix it if someone can guide me a little bit more.

from rails.

Hey @ruyrocha thanks for your respose.

I tested with the stable branch and, it doesn't work.

There is a problem in your sample file.

When you use:

  environment_logger = ActiveSupport::Logger.new(env_logger_file).tap { |logger| ActiveSupport::TaggedLogging.new(logger) }

You are using tap but tap doesn't return the block result. So the environment_logger isn't configured with the TaggedLogging, that why it works fine in your sample.

I replaced the tap for then so the environment_logger variable is also a TaggedLogging instance and it throws the same error.

TypeError: no implicit conversion of String into Integer

from rails.

The headers are correctly set as Rack::Headers, not an Array, while running your reproduction script against the main branch.

This is the passing script for 7-1-stable branch:

class TestApp < Rails::Application
  config.root = __dir__
  config.hosts << "example.org"
  config.secret_key_base = "secret_key_base"

  tagged_logger = ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new(STDOUT))
  config.logger = tagged_logger

  env_logger_file = Rails.root.join("tmp", "#{Rails.env}.log")

  environment_logger = ActiveSupport::Logger.new(env_logger_file).tap { |logger| ActiveSupport::TaggedLogging.new(logger) }

  config.log_tags = [:request_id]

  Rails.logger = ActiveSupport::BroadcastLogger.new(config.logger, environment_logger)

  routes.draw do
    get "/" => "test#index"
  end
end

Can you please give it a try?

from rails.