Comments (3)
@dfritsch Do you intend to get a PR up with your patch?
Yep! Sorry for the delay. I'll get a PR up for this this week.
from rails.
Something seemed familiar to me when looking at the code you patched and I realised I added that in with #45298. FWIW I agree that it should be using polymorphic_name
, I didn't consider the STI case in that patch and the corresponding tests. Nice find!
from rails.
@dfritsch Do you intend to get a PR up with your patch?
from rails.
Related Issues (20)
- New docs: Consider making the content centralized on the screen
- New docs: Consider making the copy button cursor pointer
- Large arel tree causes ActiveRecord preloader to throw SystemStackError HOT 2
- Inconsistent behaviour with previous encryption schemes at global / attribute level HOT 2
- Inconsistency between `any?`/`empty?` and `size` for collection associations loaded via `inverse_of` HOT 1
- (New to Rails) Can't start the server HOT 11
- `ActiveRecord::Suppressor` not working on associations that are loaded via `inverse_of` on unsaved records HOT 4
- Assets precompile not compile activetext.css HOT 1
- ActiveSupport::Cache.expand_cache_key sometimes returns falsely same key in parallel tests HOT 11
- ActionMailer::Base.smtp_settings extra options? HOT 3
- i18n support for scaffolds? HOT 2
- Schema file naming when there is no "primary" database HOT 2
- exceptions on views failure to generate detailed error page when external handler alters erb HOT 1
- Request session id unavailable when streaming HTML
- Problem with field named timestamp and index with include HOT 2
- Is where way to disable ActiveRecord::UnknownAttributeReference check? HOT 1
- [Bug][ActiveRecord] #count(:all) on grouped query should clear ORDER BY if it clears SELECT
- Disable send_preload_links_header outright HOT 1
- Date#change crashes on leap years HOT 4
- Postgresql date type is not properly typecasted when using direct SQL queries like select_all HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails.