Comments (6)
byroot
commented on September 24, 2024
It is debatable whether it is an improvement as it incurs an extra roundtrip to the backend.
So depending on how costly it is to generate, it may be a win or a loss.
In general we don't take feature requests, so if you are interested in this I suggest attempting to implement it, and we can then debate its merits on the PR with actual code.
from rails.
wdiechmann
commented on September 24, 2024
‘extra roundtrip’ ?
the only ‘cost’ is an extra Redis - lookup - and only if there are subscribers, otherwise the ‘cost’ is offset by the lack of an insert of another background job into Redis
But no problem — I shaved 35 background jobs, each doing 1-4 SQL SELECTs eventually, off per each new punch (some time/attendance SaaS I’m building) and with projected 100’s of punches 6-8 times a day, this is serious compute I’m avoiding
I hear you - no feature requests!
No problem
… Den 12. jan. 2024 kl. 10.33 skrev Jean Boussier ***@***.***>:
It is debatable whether it is an improvement as it incurs an extra roundtrip to the backend.
So depending on how costly it is to generate, it may be a win or a loss.
In general we don't take feature requests, so if you are interested in this I suggest attempting to implement it, and we can then debate its merits on the PR with actual code.
—
Reply to this email directly, view it on GitHub <#50694 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPFXIPPXEZ3XNO45E4OOTYOD7O3AVCNFSM6AAAAABBUPAQF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYG42DINZVGQ>.
You are receiving this because you authored the thread.
from rails.
byroot
commented on September 24, 2024
the only ‘cost’ is an extra Redis - lookup
Which is exactly what I mean by "extra rountrip". You are just repeating what I said.
I hear you - no feature requests!
Note that I suggested to submit a PR.
from rails.
wdiechmann
commented on September 24, 2024
“Roundtrip to the backend” in my vocabulary implies going from the client to the server (and back) which obviously is not the case, hence my “repeating what you said"
What I guess you wanted to say: it’s debatable whether an extra Redis lookup is cheaper than inserting/performing a background job.
That is correct - provided that the background job will not do any work at all - in that case it’s in fact an extra Redis operation. If the background job is going to do any kind of work, then this ‘feature’ will save compute.
Your note on PR’s is noted
… Den 12. jan. 2024 kl. 13.58 skrev Jean Boussier ***@***.***>:
the only ‘cost’ is an extra Redis - lookup
Which is exactly what I mean by "extra rountrip". You are just repeating what I said.
I hear you - no feature requests!
Note that I suggested to submit a PR.
—
Reply to this email directly, view it on GitHub <#50694 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPFXJESIPPU7AA2J4D5A3YOEXQXAVCNFSM6AAAAABBUPAQF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGEZTAOJWGI>.
You are receiving this because you authored the thread.
from rails.
byroot
commented on September 24, 2024
What I guess you wanted to say: it’s debatable whether an extra Redis lookup is cheaper than inserting/performing a background job.
Yes, except Redis isn't the only possible Action Cable backend.
from rails.
wdiechmann
commented on September 24, 2024
I am aware of that — but CPU is CPU I guess
🙂
I’m not able to provide a PR - my rails-fu is not remotely big enough to muster such a feat, hence the misplaced issue for which I apologize! It was by no means my intention to amass the much commotion -
Have a nice weekend
… Den 12. jan. 2024 kl. 14.34 skrev Jean Boussier ***@***.***>:
What I guess you wanted to say: it’s debatable whether an extra Redis lookup is cheaper than inserting/performing a background job.
Yes, except Redis isn't the only possible Action Cable backend.
—
Reply to this email directly, view it on GitHub <#50694 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPFXI22SLGQ2I5THVI66LYOE3VNAVCNFSM6AAAAABBUPAQF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGIZDAOJRG4>.
You are receiving this because you authored the thread.
from rails.
Related Issues (20)
- ActiveRecord `attribute :foo, :bar` requires an active connection
- enable_extension in schema dump doesn't contain schema name HOT 6
- PostgreSQL array not decrypting HOT 2
- Behaviour of `autosave` associations has changed on edge HOT 5
- [ActiveRecord] delete_all on has_many with dependent: :restrict_with_error results with nullify HOT 2
- ActiveRecord::AttributeMethods::Serialization::ClassMethods.serialize is not backwards compatible 7.0 -> 7.1 HOT 6
- ActiveRecord: Issue with NULL insertion for serialized empty arrays causing database constraint violations HOT 1
- daterange with `.contains(Date)` results in malformed SQL ActiveRecord::StatementInvalid: PG::InvalidTextRepresentation: ERROR: malformed range literal: "2024-07-17"
- Custom Validators that rely on Date Comparison are now breaking in Rails 7.1/Spec test cases HOT 6
- ActiveRecord CPK issue with lookup by associations HOT 2
- Leveraging button form attribute to simplify front-end integration HOT 1
- [Doc][7.2] Migration versions [8.0] are mixed up in active_record_migrations.md HOT 1
- FormHelper#text_field build value attribute of IPAddr without prefix
- Callbacks / Validations not running for `accepts_nested_attributes_for` relation on certain values, but will run on other values, or when another value is saved together with the problematic value, or when updating the record directly HOT 6
- Rails 7.0: `form_with` does not prefix id with namespace when namespace is given HOT 1
- ActiveRecord::Reflection::AssociationReflection#polymorphic? returns nil instead of boolean. HOT 2
- Upgrading from rails 7.0 to 7.1: Rails.logger is nil HOT 5
- `QueryLogsTest#test_sql_commenter_format` fails
- PG result is nil when using `async` HOT 7
- 20 Years of Rails – Republish v0.5 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails.