Git Product home page Git Product logo

Comments (2)

matthewotto avatar matthewotto commented on August 23, 2024

Looks like this only occurs when both jquery and jquery_ujs are included twice on the page, and the 2nd jquery_ujs is included after the 2nd jQuery file.

If there are only 2 copies of jquery_ujs included on the page, but one copy of jQuery, then the "jquery-ujs has already been loaded!" message is displayed in the javascirpt console.

Steps to reproduce:

  1. Create new rails app
  2. rails generate scaffold thing name:string
  3. Added ujs and jquery scripts to bottom of app/views/layouts/application.html.erb
  4. Create new "thing"
  5. Click "destroy" link for newly created thing
  6. 2 alerts confirming "Are you sure?" (Only one delete request sent to server)
  7. No "jquery-ujs has already been loaded!" message
ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-darwin11.4.2]
jquery-rails (2.1.4)
rails (3.2.8)
Chrome 23.0.1271.95

from jquery-rails.

JangoSteve avatar JangoSteve commented on August 23, 2024

Oh that's crazy, I hadn't thought of that scenario. It makes sense though, because the way we checked before was to see if the rails bindings were present on the jQuery object, but if you create a new jQuery object, then it'd redefine the object after the rails attachments (meanwhile all the events bound to the DOM get duplicated).

This ticket should be over on rails/jquery-ujs though, not jquery-rails. But I'm not really sure how we would solve this (or to be honest, if we even should). At any rate, it did make me look at the duplicate detection again and simplify it in my latest commit.

from jquery-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.