datetime casting to DateTime when it should be Time about tiny_tds HOT 2 CLOSED

This is done explicitly to help with some 32 bit systems and/or some platforms with a spice of which ruby version. It's really a hard one to nail down and we have followed mysql2's lead on this. Looking now, I see their handling is much better and uses a few nifty macros with some good documentation.

https://github.com/brianmario/mysql2/blob/master/ext/mysql2/result.c

I'd love to accept a patch or find some time to do better with this and again copy what @brianmario has done so well :)

from tiny_tds.

Issue #47 and its pull request should address this. I have asked @luislavena to take a look at see if this has any impact on Windows, which I doubt. But then again, I have no idea if the data type for seconds "uint64_t" is something that would throw off a 32-bit Windows system. Just raw ignorance on my part.

I refactored the code comments slightly for my personal taste and I also created a ruby32bit test helper based on your code. Lastly, I did confirm that this does work on my 64bit system in all the ruby versions I care about. I also tested the SQL Server adapter 3.1 using this master version of TinyTDS and found no problems. So far this is great and I really appreciate you doing a superb pull request!

from tiny_tds.