2.2.19 breaks on tables with non-ASCII chars in column names about activerecord-sqlserver-adapter HOT 7 CLOSED

Just getting to looking at bugs. Have you defined a regex that addresses this?

from activerecord-sqlserver-adapter.

We couldn't figure out exactly why and where it failed (on the UTF-8 characters? On some UTF-8 settings?) so we simply excluded that field from the list of fields passed to the adapter. It's only a workaround, but it works for now.

I'm sorry we're not more useful in this :(

from activerecord-sqlserver-adapter.

I'll keep this open and hopefully someone can post more info

from activerecord-sqlserver-adapter.

FYI, I tried last night to add a test for this and if failed badly. Maybe someone can pickup up where I left off and debug this? Here is what I did. First I changed the columns method to create a SQLServerColumn with a name that was correctly encoded. See below.

def columns(table_name, name = nil)
#...
sqlserver_options = ci.except(:name,:default_value,:type,:null)
column_name = SQLServerColumn.string_to_utf8_encoding(ci[:name])
SQLServerColumn.new column_name, ci[:default_value], ci[:type], ci[:null], sqlserver_options

Then in unicode_test_sqlserver.rb I created a new context "Testing unicode column names" and added a column to the our unicode test table like so.

SqlServerUnicode.connection.add_column :sql_server_unicodes, 'arcångel', :string

Then started writing some assertions. I found that I was making headway and getting the column definition for the name back in unicode, but all other insert/update SQL statements were failing due to some 8BIT-ASCII/UTF-8 mix match. Perhaps someone can pick this up and dig around more?

from activerecord-sqlserver-adapter.

Hi Ken,

Perhaps someone can pick this up and dig around more?
Yes I am willing to do so, BUT currently I have some problems to run
rake test on Windows...

from activerecord-sqlserver-adapter.

FYI
http://yehudakatz.com/2010/05/17/encodings-unabridged/

"The problem of incompatible encodings is likely to happen in Western applications only when combining ISO-8859-* data with Unicode data"

The vast majority of encoding bugs to date have resulted from outdated drivers that returned BINARY data instead of Strings with proper encoding tags.

from activerecord-sqlserver-adapter.

Old and closing

from activerecord-sqlserver-adapter.