Comments (1)
Yes, this would speed up the insertion of new items, but I guess not much. The current code uses a pointer to the last element of the list. The test for *list
or *start
to be a NULL pointer can not be dropped, so you save only one assignment. The current code is basically this:
(*last)->next = item;
item->next = NULL;
*last = item;
Are you suffering from performance issues? I doubt this would be noticeable, not even with large numbers of additions, which we don't have in practice anyway?
from libcgi.
Related Issues (19)
- remove md5 HOT 5
- rewrite logging HOT 2
- sess_file_rewrite() calls cgi_init_headers() HOT 1
- memory leak in cgi_process_form()
- segfault in slist_delete() if list contains only one element
- segfault in slist_delete() if list contains no elements
- slist_delete() updates list pointer to wrong value
- possible memory leak with sessions HOT 2
- switch build system to CMake HOT 2
- memory leak calling cgi_unescape_special_chars() HOT 2
- segfault in slist_item() when value is NULL HOT 1
- sess_initialized is never reset
- Memory Leak HOT 1
- cgi_param_multiple() is broken, potentially causing endless loop in actual usage HOT 3
- When crosscompile and not create prefix's lib and include then make install will fail HOT 2
- Move documentation to header
- Avoid use of `libcgi_error()` and add real error handling
- base64 implementation throws warnings with clang-tidy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libcgi.