Git Product home page Git Product logo

Comments (9)

benoitgrelard avatar benoitgrelard commented on June 24, 2024 1

A few thoughts:

  • It seems you are using the primitives, not the design system, so your issue is in the wrong repo. It should be here instead: https://github.com/radix-ui/primitives
  • I still can't seem to reproduce the issue on your sandbox.
  • On another note, you are trying to create a select out of a dropdown menu. You really shouldn't be doing as these are inherently different wai-aria patterns and thus will cause accessibility issues.

We will soon have a Select primitive which is the correct pattern for what you are trying to achieve.

from design-system.

benoitgrelard avatar benoitgrelard commented on June 24, 2024 1

Hey @kyle-platt, we have been able to reproduce the issue in a simplified setup.
It seems it's a very particular set of circumstances that produces it.
I've created an issue on the primitives side: radix-ui/primitives#540

Thanks for bringing this to our attention! 🙏

from design-system.

peduarte avatar peduarte commented on June 24, 2024

Hmm! Thanks for raising this. We have a big PR on the way so I'll see if I can address it there

from design-system.

kyle-platt avatar kyle-platt commented on June 24, 2024

Okay great to hear. Thanks!

from design-system.

kyle-platt avatar kyle-platt commented on June 24, 2024

Hey @peduarte It looks like that PR was merged. Did anyone get the chance to address this?

from design-system.

peduarte avatar peduarte commented on June 24, 2024

@kyle-platt I've had to take some time off, but pinging @benoitgrelard to assist.

from design-system.

benoitgrelard avatar benoitgrelard commented on June 24, 2024

Hey @kyle-platt I've been trying to reproduce what you're seeing but haven't been able to.
Here's a sandbox with our design system's DropdownMenu:

https://codesandbox.io/s/trusting-mirzakhani-qr58m?file=/src/App.js

If you can fork this and somehow manage to reproduce your issue, that would be very helpful 🙏

from design-system.

kyle-platt avatar kyle-platt commented on June 24, 2024

Hey @benoitgrelard here's our component stripped down a bit. Happy to help on this. Let me know if you have any questions or concerns. https://codesandbox.io/s/radix-dropdown-example-gv28o

from design-system.

kyle-platt avatar kyle-platt commented on June 24, 2024

@benoitgrelard thank you for the helpful insight. My apologies for the wrong repo. I also wasn't aware of the difference between a select and a dropdown menu. I look forward to playing around with the Select primitive once that's released!

from design-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.