Comments (9)
A few thoughts:
- It seems you are using the primitives, not the design system, so your issue is in the wrong repo. It should be here instead: https://github.com/radix-ui/primitives
- I still can't seem to reproduce the issue on your sandbox.
- On another note, you are trying to create a select out of a dropdown menu. You really shouldn't be doing as these are inherently different wai-aria patterns and thus will cause accessibility issues.
We will soon have a Select
primitive which is the correct pattern for what you are trying to achieve.
from design-system.
Hey @kyle-platt, we have been able to reproduce the issue in a simplified setup.
It seems it's a very particular set of circumstances that produces it.
I've created an issue on the primitives side: radix-ui/primitives#540
Thanks for bringing this to our attention! 🙏
from design-system.
Hmm! Thanks for raising this. We have a big PR on the way so I'll see if I can address it there
from design-system.
Okay great to hear. Thanks!
from design-system.
Hey @peduarte It looks like that PR was merged. Did anyone get the chance to address this?
from design-system.
@kyle-platt I've had to take some time off, but pinging @benoitgrelard to assist.
from design-system.
Hey @kyle-platt I've been trying to reproduce what you're seeing but haven't been able to.
Here's a sandbox with our design system's DropdownMenu
:
https://codesandbox.io/s/trusting-mirzakhani-qr58m?file=/src/App.js
If you can fork this and somehow manage to reproduce your issue, that would be very helpful 🙏
from design-system.
Hey @benoitgrelard here's our component stripped down a bit. Happy to help on this. Let me know if you have any questions or concerns. https://codesandbox.io/s/radix-dropdown-example-gv28o
from design-system.
@benoitgrelard thank you for the helpful insight. My apologies for the wrong repo. I also wasn't aware of the difference between a select
and a dropdown menu
. I look forward to playing around with the Select
primitive once that's released!
from design-system.
Related Issues (20)
- [Select] Does not work with SSR HOT 1
- Issues with `Th` and `Td` styles HOT 1
- The source code of @modulz/primitives HOT 1
- Basic Slider Excample Broken HOT 6
- Radix Dropdown removes scrollbar when opened HOT 1
- Upgrade primitive dependencies HOT 1
- [Question]: When are you planning to include a datepicker? HOT 2
- [Question]: Is there any alternative to @radix-ui/react-polymorphic? HOT 4
- [Question] Why does the grid component align items but justify content?
- Label component not exported from index HOT 1
- Opening Sheet sets the scroll position to top HOT 5
- Include CSS reset in published bundle
- License HOT 3
- css property is not being pulled off props, causing unnecessary work
- Flex and Grid sections have id but are not indexed on the fixed left menu
- Failed build on designSystemProvider
- Bug: 'Banner' is in sidebar but not in main content (docs)
- Bug: sidebar is broken on mobile HOT 1
- Bug: Slider range not perfectly aligned with the track HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from design-system.