Git Product home page Git Product logo

Comments (4)

eli-schwartz avatar eli-schwartz commented on September 25, 2024

Using subproject wraps this is actually really easy and Meson provides all the tools and UX for making this an option without you doing anything. Just, in addition to the above patch, create the directory subprojects/ and run meson wrap install pugixml.

from r2ghidra.

trufae avatar trufae commented on September 25, 2024

What i find out is that the pugixml dependency doesnt work even if it builds it fails at runtime because the apis changed (thats why its not using the last version of pugixml). Ideally i would prefer to depend on r2's xml parser instead. So we dont depend on external things that eventually break

so im not a big fan of adding the pption to use system wide pugixml

from r2ghidra.

eli-schwartz avatar eli-schwartz commented on September 25, 2024

Just add an exact version of pugixml as a dependency. If the system version is too new, it will not be found and the bundled one is forced.

from r2ghidra.

trufae avatar trufae commented on September 25, 2024

To me that looks like an extra moving piece that makes the maintainance harder and opens the doors to new bugs. But if thats not enabled by default and distros are happy with it im fine to ship it as a temporal fix. But the proper fix would be to use r2xml instead of external code

from r2ghidra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.