Git Product home page Git Product logo

Comments (7)

jrperritt avatar jrperritt commented on September 4, 2024

Hmm. What would be the expected behavior? It's true that we should return a non-zero exit code on error, but I think in your case it would run grep either way (since you'd be getting back an error message).

from rack.

kenperkins avatar kenperkins commented on September 4, 2024

I incorrectly assumed that non-zero exit would fail to execute after the pipe.

from rack.

jrperritt avatar jrperritt commented on September 4, 2024

For that, we'd have to exit before anything was printed. We could do that, but the user wouldn't get back an error message.

from rack.

kenperkins avatar kenperkins commented on September 4, 2024

Lets just make sure we return non-zero for error cases and leave it at that.

from rack.

rgbkrk avatar rgbkrk commented on September 4, 2024

What makes us have to exit before printing? All manner of tools will print on stderr and exit with a return code.

from rack.

jrperritt avatar jrperritt commented on September 4, 2024

For that, we'd have to exit before anything was printed.

*printed to stdout

from rack.

rgbkrk avatar rgbkrk commented on September 4, 2024

Nevermind me, it looks like you handled it right in #77 + #76

from rack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.