Comments (6)
khelkun
commented on July 27, 2024
1
Thanks I'll go for this PR
Ok for the component name. I'll see if I can just keep one Dashboard component definition and export 2 distinct symbols for the same module: one wrapped/decorated by DragDropContext and the other without this wrapping.
from dazzle.
Raathigesh
commented on July 27, 2024
1
Awesome! Two exports from the same file would be nice. We could remove the decorator and have an export which wraps the dashboard component with the Dnd context as you mentioned above.
from dazzle.
Raathigesh
commented on July 27, 2024
I'm afraid there is no workaround I can think of right now since dazzle is coupled with react-dnd. Sorry about that!
from dazzle.
khelkun
commented on July 27, 2024
For my usage I declared a new component in dazzle called DashboardNoDndContext (that doesn't instantiate the DragDropContext) and rebuilt and it seems to be enough for my need. Obviously I also exported this DashboardNoDndContext in the index.js (not default export).
I can do a pull request for that: exporting a second Dashboard component that let the responsability of creating the DragDropContext to the user of Dazzle. What do you think ? (I'm also not sure how to call this alternate Dashboard component)
from dazzle.
Raathigesh
commented on July 27, 2024
That seems like a neat solution! Feel free to send a PR! how about DashboardWithoutDndContext ?
from dazzle.
armckenzie
commented on July 27, 2024
Hello, is any timeline for a release that will include this fix?
from dazzle.
Related Issues (20)
- Modifying props of widgets from Dashboard HOT 2
- Cannot resolve 'file' or 'directory' ./widgets/CounterWidget HOT 1
- React 16 support HOT 7
- Looking for maintainers HOT 9
- How to remove the webpack related matter in Dazzle HOT 6
- List of user submitted widgets
- 1.4.0 build causes "Uncaught TypeError: Super expression must either be null or a function, not undefined" error at runtime HOT 4
- Support React 16 HOT 1
- Error on Bundle.js: "Super expression must either be null or a function, not defined" HOT 5
- Typings? HOT 6
- Error building with UglifyJS: "Super expression must either be null or a function, not defined" HOT 5
- Example is not working - TypeError key
- SourceMap Error HOT 3
- drag and drop placeholder
- create-react-app run build command HOT 1
- Scalable Dynamic dashboard widgets
- Downloaded Sample project is not working. HOT 2
- Swap widgets on drop?
- Cannot read property 'map' of undefined HOT 1
- Demo not accessible HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dazzle.