macos build failed with qucsator_rf about qucs_s HOT 12 CLOSED

Yes, the Windows Github action would be useful. I am using MSYS2 to build binaries and InnoSetup to generate the installer. Here is my InnoSetup script template: https://github.com/ra3xdh/qucs_scripts/blob/master/qucs.iss

from qucs_s.

Here is Github MSYS2 workflow template: https://github.com/msys2/setup-msys2

from qucs_s.

It's need to exclude the toplevel directory from include directories list. This directory doesn't contain header files. It's need to look for old commits fixing this issue for Qucs GUI and apply the similar patch for qucsator_rf.

Are you planning to add Github action for Windows too or for MacOS only? Windows support has higher priority than MacOS.

from qucs_s.

I'm thinking of adding it for windows and macos. I can add windows support earlier.

I've been experimenting with it since i just got a new macbook.

i'm running out of time for this week. i'm thinking of speeding it up in the coming weeks.

Which installer do you prefer for the windows side installation file (ex. NSIS installer)

from qucs_s.

Thank you, github action has native windows-2022 server runner maybe using for msvc build. msys2 for building mingw variant.

from qucs_s.

I think qucsator_rf cmake file need refactoring and flex,bison,gperf,dos2unix,sed all of this needed I don't know why. Can you explain ?

from qucs_s.

I think qucsator_rf cmake file need refactoring

I don't recommend a deep refactoring of qucsator-related CMake stuff. Maybe restrict to fixing warnings from modern CMake and revert autotest stuff: https://github.com/Qucs/qucs-test This work definitely should go to the separate PR from Github actions.

flex,bison,gperf,dos2unix,sed all of this needed I don't know why

• Flex/Bison are needed to generate a parsers for different netlists
• Gperf generates some syntax analyzer tables. I don't know why the developers of Qucsator decided to use Gperf for this purpose.
• Dos2unix is needed to postprocess the files generated by gperf. Otherwise build fails on some platfroms.
• Sed is also needed for postprocessing of the files generated by gperf.

from qucs_s.

I am not able to build native Windows 10 build gperf in path but gperfappgen.exe note found error i didn't found this exe.

cmake minimum maybe be increased to 3.10 and some compiler flag set using modern cmake

from qucs_s.

I recommend to use MSYS2 environment to build qucsator_rf. It is deeply integrated with Unix shell and there may be difficulties with build using native Windows shell. gperfappgen.exe is build by GCC from the CPP files from gperfappgen.exe. It generates input tables for gperf. The EXE could be found somewhere in build directory.

from qucs_s.

I'll try MSYS2 for build, thank you

from qucs_s.

ra3xdh/qucsator_rf#3 will be fixed this issue.

from qucs_s.

I have accepted ra3xdh/qucsator_rf#3 and updated qucsator_rf submodule.

from qucs_s.