Git Product home page Git Product logo

Comments (2)

r9y9 avatar r9y9 commented on May 26, 2024

Thank you for your feedback. Comments follow:

deepvoice3_pytorch/init.py
from .version import version
this line has error
version.py is not provided.

version.py is generated during installation process (python setup.py develop). See

deepvoice3_pytorch/setup.py

Lines 31 to 36 in d990533

def create_version_file():
global version, cwd
print('-- Building version ' + version)
version_path = os.path.join(cwd, 'deepvoice3_pytorch', 'version.py')
with open(version_path, 'w') as f:
f.write("__version__ = '{}'\n".format(version))

deepvoice3_pytorch/builder.py
deepvoice3_multispeaker
inconsistent with hparams.py

Do you mean deepvoice3_vctk is better than deepvoice3_multispeaker? I choose deepvoice3_multispeaker for the builder name (not preset name) in case we can use multi-speaker dataset other than VCTK.

deepvoice3_pytorch/deepvoice3.py
line 474, (done>0.5).all()
maybe done.data is better

I'm not sure if it makes any difference. Do you think it's better?

from deepvoice3_pytorch.

bobosui avatar bobosui commented on May 26, 2024

Thanks for the quick feedback.
2. deepvoice3_pytorch/builder.py
It is not a big issue for me, I can change the hyper-parameters from "builder=deepvoice3_vctk" to "builder=deepvoice3_multispeaker" to fix it.

  1. (done>0.5).all()
    I got an error message here. I guess this is probably because I am using a lower version of pytorch, since is defined with Variable (which has no all() function in my pytorch version).

Thank you very much！

from deepvoice3_pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.