Git Product home page Git Product logo

Comments (6)

r0man avatar r0man commented on May 27, 2024

Patch with Tests welcome ...

from sablono.

r0man avatar r0man commented on May 27, 2024

I think this would also mean relacing all of those attributes with "dash" versions:
http://facebook.github.io/react/docs/tags-and-attributes.html#html-attributes

from sablono.

r0man avatar r0man commented on May 27, 2024

And what about events?
http://facebook.github.io/react/docs/events.html

from sablono.

asmala avatar asmala commented on May 27, 2024

Good point. My main concern was alignment with hiccup conventions, so for and class were the ones that were an issue. It would be trivial to write a full mapping between HTML attributes and JS DOM attributes. What do you think?

I'm preparing a pull request against your updated code. Should have it done tomorrow.

from sablono.

r0man avatar r0man commented on May 27, 2024

Hi Asmala,

thanks for the patch! I applied it an made a minor change. I
moved the camel-caseing code to the util namespace and also call
it from the interpreter in case attributes could not be optimized
at compile time. Your changed are now in 0.2.0.

Thanks Roman.

from sablono.

asmala avatar asmala commented on May 27, 2024

Happy to help! I'd like too see the common parts of the hiccup family libraries pulled into one cross-compileable library, so this was just scratching my own itch. 😉

from sablono.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.