Doesn't work in advanced optimization mode about sablono HOT 17 CLOSED

Hi piranha,

can you provide a failing test case. I can't reproduce this and
the tests I added here are working:

32d641e

Thanks, Roman.

from sablono.

Hmm.. give me few minutes, I'll try to setup a minimal project to test this.

from sablono.

Argh, it works for me properly in minimal case, but fails in bigger project. :(

from sablono.

Ok, so in minimal case it generates code like React.DOM.div({className:"jumbotron"},Af(a))}. But in my case it generates new S(null,"div.jumbotron", "div.jumbotron"). I guess that's because of ifs, right?

from sablono.

Ok, here is your minimal case :)

(ns sab-56.core
  (:require [om.core :as om :include-macros true]
            [sablono.core :as html :refer-macros [html]]))

(def app-state (atom {:text "Hello world!"}))

(defn root [P owner]
  (reify
    om/IRenderState
    (render-state [this state]
      (html
       (if-not (:auth P)
         [:div.not-here]
         [:div.jumbotron
          (:text P)])))))

(om/root app-state root (. js/document (getElementById "app")))

Works in normal mode, fails in advanced.

from sablono.

I will really appreciate if we can get this fixed today, since I'm using sablono for staticshowdown.com and rewriting all the HTML code doesn't feel as best activity right now. :-)

from sablono.

Are you using externs?

from sablono.

This works for me: https://github.com/r0man/sablono-issue-16

from sablono.

I really don't understand what's going on there. I cloned your project and it works. It doesn't work in mine though, but I don't notice any differences: https://github.com/piranha/sab-16

from sablono.

It started to work after I removed all artefacts and compiled from scratch... Is this because of pretty-print or what?

from sablono.

Your project is working fine for me as well.

from sablono.

Yes, removing :pretty-print false from my main project made it working for me as well. :) Add that (and don't forget to recompile from scratch) and you'll have it failing. %)

Thanks a lot for helping!

from sablono.

Sorry, I'm not able to reproduce this, even with :pretty-print true.

from sablono.

Hmm.. Ok, let this issue wait for tomorrow, I'll try to demonstrate this behavior better then. Right now I'm just happy that it's working. :)

from sablono.

I also don't have any problems with advanced compilation. Here extract from my project.clj:

      :optimizations :advanced
      :pretty-print false
      :preamble ["react/react.min.js"]
      :externs ["react/externs/react.js"]}}

sablono 0.2.6, om 0.3.6

from sablono.

Closing this. Can't reproduce this.

from sablono.

Sure, if I'll ever stumble upon this again I'll notify you. :-)

from sablono.