Git Product home page Git Product logo

Comments (8)

topepo avatar topepo commented on June 18, 2024 1

I'll change and do a PR. Thanks!

from generics.

ismayc avatar ismayc commented on June 18, 2024

I think this makes a lot of sense. I’m not exactly sure how others would use the verbs individually instead of in the {infer} pipeline though too, but I’m likely overlooking some use cases.

from generics.

hadley avatar hadley commented on June 18, 2024

I don't think new functions should live here; this is specifically for base functions (or functions used by many existing packages) that should be generic. I think these functions would be a better fit for modelgenerics.

from generics.

ismayc avatar ismayc commented on June 18, 2024

I was assuming this repo and modelgenerics were the same thing based on the reroute. I'm not familiar with modelgenerics but agree with Hadley that these verbs aren't particularly useful unless some kind of modeling or testing is being done.

from generics.

topepo avatar topepo commented on June 18, 2024

@ismayc we're probably going to send this to CRAN this week. Do you have any issues if I add those verbs? I don't see much downside.

from generics.

ismayc avatar ismayc commented on June 18, 2024

Nope. That works for us.

from generics.

topepo avatar topepo commented on June 18, 2024

@ismayc Can you take a look at the new branch?

I kept the signatures the same (mostly x). Visualize uses data. If (or when) you make these methods in infer, would you consider changing that to x too?

from generics.

ismayc avatar ismayc commented on June 18, 2024

@topepo Looks good to me. We should probably switch to x. I’ll add that to the to-do list.

from generics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.