Comments (8)
I'll change and do a PR. Thanks!
from generics.
I think this makes a lot of sense. I’m not exactly sure how others would use the verbs individually instead of in the {infer} pipeline though too, but I’m likely overlooking some use cases.
from generics.
I don't think new functions should live here; this is specifically for base functions (or functions used by many existing packages) that should be generic. I think these functions would be a better fit for modelgenerics.
from generics.
I was assuming this repo and modelgenerics
were the same thing based on the reroute. I'm not familiar with modelgenerics
but agree with Hadley that these verbs aren't particularly useful unless some kind of modeling or testing is being done.
from generics.
@ismayc we're probably going to send this to CRAN this week. Do you have any issues if I add those verbs? I don't see much downside.
from generics.
Nope. That works for us.
from generics.
@ismayc Can you take a look at the new branch?
I kept the signatures the same (mostly x
). Visualize uses data
. If (or when) you make these methods in infer
, would you consider changing that to x
too?
from generics.
@topepo Looks good to me. We should probably switch to x
. I’ll add that to the to-do list.
from generics.
Related Issues (20)
- Add existing generics (pillar, tibble, dplyr, tidyr) to this package HOT 1
- Add model() and estimate() generics HOT 8
- `Methods` section in roxygen docs malformed HOT 4
- Add generics from universals package?
- Add a compress(x, ...) generic HOT 2
- Re-licensing generics as MIT HOT 2
- License info HOT 1
- Release generics 0.1.0
- Adding `sum()` generic? HOT 1
- Add hypothesise() as alternative of hypothesize()
- recode generic for arules and dplyr HOT 2
- Move `master` branch to `main` HOT 1
- Add forecast() and accuracy() generics HOT 3
- deprecate `varying_args()`
- Release generics 0.1.2
- Upkeep for generics HOT 1
- Release generics 0.1.3
- I don't know where to look for the source code HOT 1
- Add generic for `bake()`
- Upkeep for generics (2023)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generics.