Git Product home page Git Product logo

Comments (9)

zxqx avatar zxqx commented on May 30, 2024 1

@rcstanciu Exactly, it has to do with the HttpProvider for the WalletConnectConnector being mistakenly instantiated with chainId: 1, which works fine when you're using mainnet, but causes this bug on other networks. I tested on mainnet after launch and didn't see the bug -- are you seeing something different?

from morphs-frontend.

zxqx avatar zxqx commented on May 30, 2024

Closing as this only happens on non-mainnet networks.

from morphs-frontend.

rcstanciu avatar rcstanciu commented on May 30, 2024

@zakangelle Does it work properly on mainnet? What about testnets like Goerli?

from morphs-frontend.

zxqx avatar zxqx commented on May 30, 2024

@rcstanciu The Morphs app supports Rinkeby testnet and Ethereum mainnet. The bug surfaces when using Rinkeby -- it will still allow you to mint, but will not show a "Minting..." message (when transaction is pending) and "Success" message (when transaction is confirmed).

from morphs-frontend.

rcstanciu avatar rcstanciu commented on May 30, 2024

And on mainnet the bug does not happen at all? The promises return as they should, like with the regular InjectedConnector?

from morphs-frontend.

rcstanciu avatar rcstanciu commented on May 30, 2024

I didn't get to the point where I can test it on mainnet. I only tried with different testnets and local hardhat node.
I was actually considering replacing wagmi before I saw you referencing that issue, but now I think I will continue working with it 😃 I'm glad everything was fine in the end! Congrats on your launch!

from morphs-frontend.

zxqx avatar zxqx commented on May 30, 2024

@rcstanciu Appreciate it! And yeah, this is my first time using wagmi and it's been great outside of this one issue -- there's a few people working on fixing it, and I'll probably take a crack at it next week too if it's still lingering. If you have any other questions when integrating it feel free to hit me up!

from morphs-frontend.

rcstanciu avatar rcstanciu commented on May 30, 2024

Thanks to you, I looked at the source code of WalletConnect connector and found a workaround. If you set the chainId to the working network, in the options object when instantiating the WalletConnectConnector, it will work. I'm not sure if it will still work after some network changes but it's a start haha.

from morphs-frontend.

zxqx avatar zxqx commented on May 30, 2024

@rcstanciu Nice! I'll have to try that out. Curious if it works w/ switching networks after initial load.

from morphs-frontend.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.