Git Product home page Git Product logo

Comments (4)

jlaine avatar jlaine commented on May 9, 2024

You are correct, and the behaviour you describe applies both to QXmpp based clients and servers. I have made a change to QXmppStream so that the end of the incoming stream triggers closing the outgoing stream. Can you please confirm this fixes your issue?

Re-reading the RFC brings to mind another issue: to be fully compliant with the RFC we should not close the TCP socket until the incoming stream has been closed. However I am reluctant to make this change at this point as I fear it will potentially cause regressions in the form of "hung" connections.

from qxmpp.

servonic avatar servonic commented on May 9, 2024

Thank you for the fix - you were too fast, I already was preparing a pull request...
Your solution looks similar to my approach, however I'm going to test it this afternoon and leave a reply.

I agree with your concern regarding the TCP socket: For instance (if my observations are correct) the client library jabber-net has a bug and doesn't close the TCP connection after receiving the closed strem.

from qxmpp.

servonic avatar servonic commented on May 9, 2024

The test was successful.
(The jabber-net based client keeps a connection in state CLOSE_WAIT, but this is a problem of jabber-net and not qxmpp.)

from qxmpp.

jlaine avatar jlaine commented on May 9, 2024

Good news!

from qxmpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.