Transaction support? about dotsql HOT 10 OPEN

Feel free to open a PR, I'll be happy to review it

from dotsql.

Not sure if transactions should concern dotsql. You can start a transaction with begin and the call queries loaded from dotsql.

from dotsql.

closing this, but if you think I'm missing something, feel free to reopen it

from dotsql.

Not sure if transactions should concern dotsql. You can start a transaction with begin and the call queries loaded from dotsql.

Maybe I'm missing something, but in this case you need to get a raw query and execute it manually, which is probably less convenient, that just have a wrapper around Tx in the library itself.

from dotsql.

@erthalion how would you do it? Could you provide pseudo-code to better understand your idea?

from dotsql.

For now I'm doing something like that in my code, is that what you're asking?:

func (d DotSql) ExecTx(tx *sql.Tx, name string, args ...interface{}) (sql.Result, error) {
	query, err := d.lookupQuery(name)
	if err != nil {
		return nil, err
	}

	return tx.Exec(query, args...)
}

from dotsql.

@erthalion I understand better now, it shouldn't be hard to implement right?

from dotsql.

Yeah, of course - just originally I had strong feeling that such simple thing is already implemented here somewhere :)

from dotsql.

Why was ExecTx removed form the v1.0.0 release? I was utilising this.

from dotsql.

Which version / commit hash are you using?

from dotsql.