Comments (12)
Yeah it's broken, and I didn't notice because it is
- NOT broken when installing with
pip install -e .
and testing in the dinglehopper source directory - broken when installing with
pip install .
Great joy.
from dinglehopper.
👀 @bertsky
There was some confusion, I thought it was fixed, etc. etc.
from dinglehopper.
There was some confusion, I thought it was fixed, etc. etc.
Yes, still broken AFAIK. (For example, @kba just re-instated that version on ocrd_all, and voila it broke the CI again.
from dinglehopper.
There was some confusion, I thought it was fixed, etc. etc.
Yes, still broken AFAIK. (For example, @kba just re-instated that version on ocrd_all, and voila it broke the CI again.
Yeah I know now (since Friday) and will fix it today
from dinglehopper.
@kba I'm probably "over-communicating" but just to make sure: I thought the remaining issue is eynollah having the old style namespace but that's another, second problem.
from dinglehopper.
@kba I'm probably "over-communicating" but just to make sure: I thought the remaining issue is eynollah having the old style namespace but that's another, second problem.
Over-communicating is just fine :-) We should fix all the qurator namespace changes in one fell swoop, test them and create a new release of ocrd_all then. For now, the latest ocrd_all release contains dinglehopper in the commit just before the namespace change.
from dinglehopper.
Note to self: In this case, testing the install in a fresh virtualenv also was necessary.
from dinglehopper.
We should fix all the qurator namespace changes in one fell swoop, test them and create a new release of ocrd_all then.
Is it really inevitable to change namespace pkg implementation? Is there no other way around the deprecation warning?
I am pretty sure this will fall on our feet again and again, because installations will not be equally "swooped" to the new versions likewise. (And we cannot even solve this via version requirements, because none of the qurator packages depend on each other.)
from dinglehopper.
I have a fix ready (calling find_namespace_packages is necessary) but I can't push currently due to GitHub's problems.
from dinglehopper.
I am pretty sure this will fall on our feet again and again, because installations will not be equally "swooped" to the new versions likewise. (And we cannot even solve this via version requirements, because none of the qurator packages depend on each other.)
The decision is up to @qurator-spk/dev, I only noticed the deprecation warning. IIUC one of the reasonings for adapting this is that QURATOR project has ended, MMK project has begun and this would be part of the consolidation.
As for breaking installations: As long as people follow the upgrade instructions (deactivate/remove venv, make all
for native; docker pull ocrd/all
for docker) that should™️ not be a problem.
from dinglehopper.
I've now removed the namespace prefix (s/qurator.dinglehopper/dinglehopper
and associated changes) altogether.
from dinglehopper.
Just to over-communicate again: It should be fixed now, and if you still have problems with git master, please open a new bug!
from dinglehopper.
Related Issues (20)
- Test cli_line_dirs
- Tests broken, again HOT 4
- Review API w.r.t. to keyword only arguments HOT 1
- Tests failing + Wrong badge HOT 5
- mypy vs pre-commit mypy HOT 2
- newlines not removed in plain_extract HOT 5
- Windows support HOT 5
- Python 3.12 support broken HOT 3
- Confusing "Tests Report" in GH Actions
- Test CLIs
- Test reports broken HOT 3
- Add TEI support
- Review changes of #83
- setup.cfg → pyproject.toml HOT 3
- Install is now broken HOT 2
- GitHub Actions HOT 1
- Review multimethod dependency
- Regression with newest ocrd version HOT 4
- dinglehopper --version, ocrd-dinglehopper --version HOT 1
- Detect if no text was extracted / if there are grave inconsistencies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dinglehopper.