add notes to an ayah about quran_android HOT 13 OPEN

i shall start working on adding notes..

from quran_android.

What is the status of this issue ? Still valid ? Any previous work done is in source code ?

from quran_android.

@ahmedre @afarra @hmaher
what is the status of this issue?

from quran_android.

already implemented by @afarra still we need to finalize UI

from quran_android.

@afarra can you add a new fragment that lists notes ?
still we didnt decide how to view the note's marker in page view

from quran_android.

Sure.

Should I also split bookmarks and tags into separate fragments as well or leave as is?

from quran_android.

i was telling @hmaher that in my humble opinion, we shouldn't do both. we should just have bookmarks and bookmark categories and forget about tags. very few people understand tags (mostly advanced users) and categories give them the same functionality.

from quran_android.

lol, these names are causing too much confusion... when I say tags, I mean the same thing as bookmark categories, aka collections...

ok, let's pick terms so there's no more confusion.. currently there are three things:

1. Categories that hold a single ayah/page item and when you add a new item to the category it replaces whatever was there previously
2. Categories that hold multiple ayah/page items, adding a new one to that category is like adding to a folder
3. The ayah/page items themselves that go into the different categories

What should each of 1, 2, and 3 be called?

When you say "we should just have bookmarks and bookmark categories" you mean 1 and 2, right?

from quran_android.

notes is already implemented by @afarra and the code is just commented out.
we need a better ui before we can enable it.

from quran_android.

• we can enable notes listing as a tab (like bookmarks and tags)
• ayah context menu shall have an option for note editing, which shall open in a popup (similar to fb comments popup)

from quran_android.

you can go ahead and add another tab for notes if you'd like.
as for inside the sura, we're moving to the ui mockup that we had in dropbox at some point.
it's not highest priority since there are more critical things to deal with first.

from quran_android.

I'll get this done before Ramadan release in sha Allah.

from quran_android.

What is the status on this?

from quran_android.