Comments (9)
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on January 05, 2010 11:29:01
Don't know if Joe is looking at "Fixed" issues, so I made a new issue#50 out of it.
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on December 29, 2009 14:15:16
Note that the bug I introduced with r69 only appeared when actually using the new
functionality, for example assigning multiple genres. In that case the bug is fatal, but at
least it is not a regression.
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on December 29, 2009 14:10:08
There was a problem with my patch. I'm sorry! I've never coded python before. Here is a fix:
Attachment: mid3v2.diff
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on December 28, 2009 10:35:03
This issue was closed by revision r69 .
Status: Fixed
Mergedinto: -
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on December 28, 2009 09:52:59
Good point. How's the attached?
Note that the biggest part of the attached diff is just an indentation change: the block
between
values = value.split(":")
and
encoding=3, text=value, lang=lang, desc=desc)
is now within a loop over vlist.
Attachment: mid3v2.diff
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on December 12, 2009 20:22:58
I am unclear where the atomic_types variable is supposed to come from. Can you change
that whole bit so the edits dict just always holds the right type, and we don't need
to postprocess the preprocess?
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on November 24, 2009 16:02:36
Status: Accepted
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on November 17, 2009 09:51:03
Okay, here is (as far as I can see) the final version of this patch.
I reversed the order of applying the "--delete-frame" and "--FRAME=value" operations.
It makes more sense to first apply the deletes, then the writes. This way a script can
first summarily delete all occurrences of certain frames, and then add the correct
values back in.
Attachment: mid3v2.diff
from mutagen.
Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):
From [email protected] on November 06, 2009 10:59:29
Sorry, got a mistake when I refreshed my diff against SVN, here is the corrected
version
from mutagen.
Related Issues (20)
- Support for other video formats HOT 1
- Write into FLAC files via cli HOT 1
- File objects with no tags cast to boolean as false
- wav file bps incorrectly identified as absurdly high value HOT 3
- Unclear what the build system is HOT 5
- Mutagen updates ID3v1 tags but does not save ID3v2 tags HOT 4
- MP4.save() makes phone videos unreadable (Invalid NAL unit size)
- Having problems figuring out how to write to ID3 tags for MP3's HOT 2
- Updating APIC tag leads to empty cover art on Spotify's local files
- Performance on NFS-mounted files much helped by specifying buffering
- mutagen-inspect shows tag data but mid3cp shows HOT 4
- OGG Vorbis file save fails: mutagen.ogg.error: unable to read full header; got b'\x00\x00' HOT 3
- Can't open wav ripped from DVD audio: Invalid Chunk - ordinal not in range(128) HOT 6
- OGG Vorbis: wrong (playback) duration / length reported on opus audio HOT 1
- "Universal" audio metadata class HOT 3
- Extensible wave format support HOT 2
- FLAC objects that compare equal do not have the same hash value
- mid3v2 not working with .opus files. HOT 4
- Unable to add artwork to `.ogg` [vorbis] file HOT 9
- Add support for Audiobooks (.m4b) tags to EasyMP4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mutagen.