Remove Cargo.lock from repository about tantivy-cli HOT 5 CLOSED

I think this is the right practise for crates producing a binary.

The cargo.lock is not supposed to be updated if the versions in it are compatible with the cargo.toml.

from tantivy-cli.

I think this would be ok if we have exact version number for each component. Not something like:
clap = "2"

Since now when I clone this repo and run cargo build on it Cargo.lock will be modified. It doesn't force exact versions numbers on my side.
It means that if I will create PR it will always contain modified 'Cargo.lock` in it.

from tantivy-cli.

I misunderstand your ticket. (the title is quite misleading)

You just want to add it to .gitignore is this correct?
I'd like to keep it as is to ensure I don't forget updating it on releases.

I'm ok with adding

.idea/
*.iml

to .gitignore.

I'm not sure about Cargo.lock.

I am a bit afraid I might forget to ever update it if it is on .gitignore.

It means that if I will create PR it will always contain modified 'Cargo.lock` in it.

Only if you create your commit by adding all modified file into it.

from tantivy-cli.

My main point was about adding Cargo.lock to .gitignore and remove it from the git repo.

But after reading rust documentation it looks that they recommend for binaries adding Cargo.lock to the repo.
The problem here is then that cargo build shouldn't update cargo.lock on my computer. It should instead pick the right versions from this file.
Not sure why this happened.

from tantivy-cli.

I think the meta reason is that I updated master and not develop. You might want to retry. Closing. Please send a PR if you want to put your editor files in the .gitignore file. I'm ok with that.

from tantivy-cli.