Comments (4)
Is that incorrect? You can have a closed QUIC server, while the HTTP/3 server is still running.
from quic-go.
what is a "QUIC server" when working at HTTP/3 api level ? Do we need to know about such 'quic' stuff at this level ?
The http3 package tries to reproduce the same API as the net/http
package.
With net/http
, when we use ListenAndServeTLS
or just ServeTLS
and the call ends, it means the server stopped. As per the documentation:
ServeTLS always returns a non-nil error. After Shutdown or Close, the returned error is ErrServerClosed.
source: https://pkg.go.dev/net/http#Server.ServeTLS
So when http3.Server.Serve
(...) ends, if the returned error is quic.ErrServerClosed
what is the meaning of this ?
If we have existing code that use net/http and check for http.ErrServerClosed
, when we switch or add http/3 we must add a special case to check for quic.ErrServerClosed
which is confusing (which is what we're currently doing now).
from quic-go.
Should we replace the error if s.closed == true
?
from quic-go.
Should we replace the error if
s.closed == true
?
no that's the only place where it is correct.
other return paths should be changed.
from quic-go.
Related Issues (20)
- Bug: parse the wrong ServerName from addr HOT 3
- CRYPTO_ERROR 0x12a (local): tls: failed to verify certificate: x509: cannot validate certificate for <IP> HOT 4
- saving the datagram size in the session tickets breaks 0-RTT tests HOT 1
- Quic-go server does not discard all the Initial packets with a payload size smaller than the minimum allowed maximum datagram size of 1200 bytes. HOT 1
- make the key used for encrypting NEW_TOKEN tokens configurable
- How to specify the source port number when a client wants to Dial to server HOT 6
- Hello, can you help me find out what causes the timeout: no recent network activity error? HOT 5
- provide Prometheus metrics
- File doesn't exist!! HOT 1
- Possible context leak in EarlyConnection.HandshakeComplete() HOT 3
- Usage of Address Validation Tokens and 0-RTT on Chromium-based devices HOT 5
- Unable to create connection from non-golang client HOT 13
- http3: HEAD method should not have a body HOT 5
- http3: add support for RFC8878 `Content-Encoding: zstd` to `RoundTripper` HOT 5
- Run govulncheck HOT 1
- IPv4 connections to quic-go server fail on FreeBSD HOT 7
- Incorrect ecnIPv4DataLen on FreeBSD HOT 1
- OpenStreamSync non-blocking HOT 3
- inconsistent packet size HOT 7
- add non block socket support HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quic-go.