Git Product home page Git Product logo

Comments (4)

marten-seemann avatar marten-seemann commented on June 23, 2024

Is that incorrect? You can have a closed QUIC server, while the HTTP/3 server is still running.

from quic-go.

kgersen avatar kgersen commented on June 23, 2024

what is a "QUIC server" when working at HTTP/3 api level ? Do we need to know about such 'quic' stuff at this level ?
The http3 package tries to reproduce the same API as the net/http package.

With net/http, when we use ListenAndServeTLS or just ServeTLS and the call ends, it means the server stopped. As per the documentation:

ServeTLS always returns a non-nil error. After Shutdown or Close, the returned error is ErrServerClosed.
source: https://pkg.go.dev/net/http#Server.ServeTLS

So when http3.Server.Serve(...) ends, if the returned error is quic.ErrServerClosed what is the meaning of this ?

If we have existing code that use net/http and check for http.ErrServerClosed, when we switch or add http/3 we must add a special case to check for quic.ErrServerClosed which is confusing (which is what we're currently doing now).

from quic-go.

marten-seemann avatar marten-seemann commented on June 23, 2024

Should we replace the error if s.closed == true?

from quic-go.

kgersen avatar kgersen commented on June 23, 2024

Should we replace the error if s.closed == true?

no that's the only place where it is correct.

other return paths should be changed.

from quic-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.