doesn't work with new node-fetch about fetch-ponyfill HOT 8 CLOSED

This library is intended to be a thin wrapper around the browser fetch-polyfil first, and isomorphic second. That being said, I'd like to see a reduction to see this behaviour in action. Could you show me how to reproduce this please?

from fetch-ponyfill.

I've made a gist:

https://gist.github.com/mienaikoe/adc59f9e72e98c287498318a96998f33

from fetch-ponyfill.

my npm dependency list for this is:

"dependencies": {
"es6-promise": "^3.2.1",
"fetch-ponyfill": "^1.0.0"
}

from fetch-ponyfill.

Are this library's current tests reproducing the problem with the affected version of node-fetch?

from fetch-ponyfill.

Tests run fine as they are. In the tests, I tried replacing 'promise' with 'es6-promise', and I got the same error. I believe this is because 'es6-promise' does not replace the global Promise with itself unless you ask it to do so. 'promise' probably does.

In node-fetch, you can see where it sets Fetch.Promise to be whatever global.Promise is. If global promise doesn't exist, then this will remain as undefined.

The problem arises in the setting of "fetch.Promise", which does nothing. if you want to make a difference to node-fetch, you should be using "Fetch.Promise"

from fetch-ponyfill.

Ah, the problem is in your require. It looks like you need to change

Promise: require('es6-promise')

to

Promise: require('es6-promise').Promise

from fetch-ponyfill.

@mienaikoe did @paulmelnikow's suggestion help?

from fetch-ponyfill.

Yea. Realized that requiring es6-promise just puts it into the global scope. Paul's suggestion actually assigns it. Closing.

from fetch-ponyfill.