Git Product home page Git Product logo

Comments (8)

cescoffier avatar cescoffier commented on September 21, 2024

Since quarkusio/quarkus@b89fece#diff-f15233cea0f87118b4441038738a41197a55fb6e3e1f3e06efd1dc4b41fe0143R160, the Kubernetes services created by Quarkus now contain two ports:

  • HTTP (8080)
  • HTTPS (8443)

The problem with the two ports is that our application exposes a single one, so the second one will constantly fail.

When Stork lists the endpoint ports, it finds the two ports and does not know which one to use. So, it picks the first one, which has 50% of selecting the wrong one.

@Sgitario added a feature to Stork that allows selecting the port. However, having a new, almost mandatory attribute for something that should not be is inconvenient. But that's a workaround until we can improve the generation.

\CC @Sgitario @iocanel

from quarkus-super-heroes.

cescoffier avatar cescoffier commented on September 21, 2024

With quarkusio/quarkus#33237, you would need to set port-name: http for the clients using stork.

from quarkus-super-heroes.

edeandrea avatar edeandrea commented on September 21, 2024

I did try that but still did not work.

from quarkus-super-heroes.

cescoffier avatar cescoffier commented on September 21, 2024

from quarkus-super-heroes.

Sgitario avatar Sgitario commented on September 21, 2024

I tried quarkusio/quarkus#33237 with quarkusio/quarkus#33131 and the new property works fine: quarkusio/quarkus#33131 (comment)

from quarkus-super-heroes.

edeandrea avatar edeandrea commented on September 21, 2024

I haven't tried it yet. How would I do that? Build Quarkus main and then build super heroes off of that?

from quarkus-super-heroes.

cescoffier avatar cescoffier commented on September 21, 2024

@edeandrea no need for the full quarkus. Just use Stork 2.2.0 (set the dependency version on the kubernetes service discovery dependency).

The PR bumping the Stork version in Quarkus has been opened. I hope it will be merged and include for the next release (cut today if I'm not mistaken).

from quarkus-super-heroes.

cescoffier avatar cescoffier commented on September 21, 2024

The fix has been integrated in the latest Quarkus release:
https://github.com/quarkusio/quarkus/releases/tag/3.0.3.Final

from quarkus-super-heroes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.