Better handling of defaults about qgrid HOT 3 OPEN

ping @aggFTW

from qgrid.

@ellisonbg can you elaborate on what you mean by Right now, defaults are handled outside the QGridWidget class.? We maintain a global instance of _DefaultSettings in the grid module, so that you can apply settings to all the grids you create, but that's still configurable on a per-instance basis, and we should be making a copy of the settings when we instantiate a new instance. If there are bogus entries in that settings dict by default, then that's just a bug I think.

from qgrid.

In general, widgets and traitlets.HasTraits classes shoudl put the default
value in one of 2 locations:

• Use the default_value kw arg to the Trait itself
• Define a _foo_default method that returns the default.

This will enable the class to be instantiated with no explicit args if
needed, and the module level overrides will only need to set those values
that are different from the class defaults. I think it is fine to have the
module level API for settings things, but those should not contain the
defaults just overrides of the actual class defaults.

On Mon, Nov 2, 2015 at 7:49 PM, Scott Sanderson [email protected]
wrote:

@ellisonbg https://github.com/ellisonbg can you elaborate on what you
mean by Right now, defaults are handled outside the QGridWidget class.?
We maintain a global instance of _DefaultSettings in the grid module, so
that you can apply settings to all the grids you create, but that's still
configurable on a per-instance basis, and we should be making a copy of the
settings when we instantiate a new instance. If there are bogus entries in
that settings dict by default, then that's just a bug I think.

—
Reply to this email directly or view it on GitHub
#43 (comment).

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

from qgrid.