The list built-in is overridden Thanks for your beautiful work :)

This seems to have been fixed in <a class="commit-link" data-hovercard-type="commit" d

built-in overriden in "correctness -> else clause on loop without a break statement" about python-anti-patterns HOT 3 OPEN

quantifiedcode commented on August 16, 2024

built-in overriden in "correctness -> else clause on loop without a break statement"

from python-anti-patterns.

Comments (3)

BrunoDesthuilliers commented on August 16, 2024

in https://docs.quantifiedcode.com/python-anti-patterns/correctness/else_clause_on_loop_without_a_break_statement.html :

def contains_magic_number(list, magic_number):
    for i in list:

:-)

from python-anti-patterns.

CastixGitHub commented on August 16, 2024

Talking about correctness, instead of break, I think return is more appropriate here

>>> def contains_magic_number(numbers, magic_number):
...     for n in numbers:
...             if magic_number == n:
...                     return True
...     else:
...             return False
... 
>>> print("This list contains the magic number."
...       if contains_magic_number(range(10), 5)
...       else "This list does NOT contain the magic number.")
This list contains the magic number

otherwise do not use a loop at all, use a list comprehension or filter() instead

>>> def contains_magic_number(numbers, magic_number):
...     if len([n for n in numbers if n == magic_number]) != 0:
...             print("This list contains the magic number.")
...     else:
...             print("This list does NOT contain the magic number.")
... 
>>> contains_magic_number(range(10), 5)
This list contains the magic number.