Git Product home page Git Product logo

Comments (7)

qqmyers avatar qqmyers commented on August 16, 2024 1

FWIW: This issue has some things that are common across the existing previewers (which all share some common HTML), so when I fix those, it should work across the whole set.

from dataverse.

adam3smith avatar adam3smith commented on August 16, 2024

Looks like these aren't fixed yet, correct?

from dataverse.

qqmyers avatar qqmyers commented on August 16, 2024

They were - at least the ones from the previewer framework - just not deployed on stage. I updated them now. You may still see issues with, for example, the spreadsheet viewer that come from the table display library, or the pdf library, etc.

from dataverse.

qqmyers avatar qqmyers commented on August 16, 2024

FWIW, these should be independent of Dataverse, so they can be updated in place on prod at any time.

from dataverse.

adam3smith avatar adam3smith commented on August 16, 2024

I'm seeing this (which is flagged as a hidden form field missing a label by WAVE) at the bottom of the code, below the footer:

<div id="CopyPasteDiv" style="position: fixed; top: -10000px; left: -10000px;"><textarea class="copyPaste" style="width: 10000px; height: 10000px; overflow: hidden; opacity: 0;"></textarea></div>

Doesn't look like this was previously there, nor is it doing anything?

from dataverse.

adam3smith avatar adam3smith commented on August 16, 2024

WAVE is also complaining about a missing table header above the row number. Not sure about best practices here -- could we hide a header (because it's obvious for people visually what this is)?

from dataverse.

qqmyers avatar qqmyers commented on August 16, 2024

FWIW: I believe these errors are both from the table widget in use for the spreadsheet viewer (https://handsontable.com/). I've flagged these in gdcc/dataverse-previewers#4 - also just noted there that the spreadsheet previewer is way behind, using v0.28.4 from ~2016, so it's possible that upgrading will fix/change the issues.

from dataverse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.