Describe the bug Attempted to use the "1dfmm" method to calculate

[BUG]: skfmm LUT generation doesn't work for the southern hemisphere about quakemigrate HOT 2 CLOSED

quakemigrate commented on June 9, 2024

[BUG]: skfmm LUT generation doesn't work for the southern hemisphere

from quakemigrate.

Comments (2)

TomWinder commented on June 9, 2024

Confirming the same bug affects Linux (Ubuntu 20.04 / Python 3.8 / QuakeMigrate 1.0.0):

1dnlloc traveltimes:

CBJI 4.93516939247
CBJM 7.46098649797
CCJM 6.92342233406
CWJM 7.81328655045
DBJI 9.79183836983
JPJI 8.55424903482
JTJM 10.6687429621
LEM 11.5750472581
PBJI 11.5753167666
SCJM 3.84283267304
SPSJM 11.4048941522
SSJM 5.62294754896
WSJM 10.8150932759

vs 1dfmm traveltimes:

CBJI 4.74641187468
CBJM 5.55452430853
CCJM 6.64352053357
CWJM 2.92746251661
DBJI 5.3082381857
JPJI 3.32778470283
JTJM 8.40255334532
LEM 3.72185884826
PBJI 7.54072961752
SCJM 3.72839355312
SPSJM 3.32371759491
SSJM 5.45511447601
WSJM 7.54029014689

Note e.g. that CWJM has the shortest traveltime with 1dfmm, but one of the longest for 1dnlloc.

from quakemigrate.

TomWinder commented on June 9, 2024

D'oh - this is actually due to trying to use stations outside the grid, which is not supported for 1dfmm.

This requires an error message if someone tries to do so. Something like:

if (lut.stations_xyz < lut.ll_corner).any() or (lut.stations_xyz > lut.ur_corner).any():
    raise ValueError("Cannot calculate traveltimes with method '1dfmm' unless "
                     "all stations are contained within the grid! Please either "
                     "use method '1dnlloc' or increase the grid extent to "
                     "contain all stations")

from quakemigrate.

Recommend Projects