Git Product home page Git Product logo

Comments (10)

colinbrislawn avatar colinbrislawn commented on July 26, 2024 9

Yep. 2018.6 (June) gives me plenty of time to get this right.

I do most of my analysis in R, so I'll be leaning the APIs for q2_types and unit testing as I go.

from q2-vsearch.

gregcaporaso avatar gregcaporaso commented on July 26, 2024 2

I can do this for 2017.11.

from q2-vsearch.

wasade avatar wasade commented on July 26, 2024 1

Excellent. We seem green on 2.5.0 with Deblur, and it is in bioconda, should we push forward with that?

from q2-vsearch.

jairideout avatar jairideout commented on July 26, 2024 1

q2-vsearch now relies on vsearch >=2.5.0 so this issue is no longer blocked (fixed in #27).

from q2-vsearch.

thermokarst avatar thermokarst commented on July 26, 2024

The 2.0.3 version pin appears to be coming from the upstream deblur package; we don't appear to be pinning anywhere in the QIIME 2 org on Github.

from q2-vsearch.

wasade avatar wasade commented on July 26, 2024

I'm working on biocore/deblur#158 but I cannot find a conda installable vsearch==2.1.1. @gregcaporaso, were you installing from an existing repository or by source? I looked at biocore, bioconda and qiime2. However, it seems that Deblur works with vsearch==2.5.0 so it may just be quite insensitive to the version. Verifying right now.

from q2-vsearch.

gregcaporaso avatar gregcaporaso commented on July 26, 2024

Hmm, I may have installed from source. I don't think there should be any issue with using 2.5.0 though (if that one is on conda) - as far as I know, the other plugins that use vsearch don't have a version pinned. It'd be ideal to just bump to the most recent version.

from q2-vsearch.

jairideout avatar jairideout commented on July 26, 2024

πŸ‘ for obtaining vsearch 2.5.0 from bioconda. Can you remove the version pin entirely from the Deblur recipe, or set a minimum version, so that we can keep up-to-date with vsearch releases moving forward?

from q2-vsearch.

colinbrislawn avatar colinbrislawn commented on July 26, 2024

I can add support for --derep_prefix
Thanks for building the list of good first issues!

from q2-vsearch.

thermokarst avatar thermokarst commented on July 26, 2024

Thanks @colinbrislawn - the PR freeze started last week for 2018.4, so I don't think this will be able to make it into this release, but we can certainly add it into 2018.6 - does that work for you?

from q2-vsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.